Skip to content

Remove Kyber completely#2941

Merged
torben-hansen merged 4 commits intoaws:mainfrom
torben-hansen:remove_kyber_ref3
Jan 15, 2026
Merged

Remove Kyber completely#2941
torben-hansen merged 4 commits intoaws:mainfrom
torben-hansen:remove_kyber_ref3

Conversation

@torben-hansen
Copy link
Copy Markdown
Contributor

@torben-hansen torben-hansen commented Jan 13, 2026

Issues:

  • CryptoAlg-3052
  • V2065732656

Description of changes:

Kyber has turned into ML-KEM and is no longer needed. Also remove some remnants of Dilithium and correct som inaccurate text in various files which wasn't updated when switching to ML-[KEM,DSA].

Did a bunch of grep -ri "kyber" ./ and axed everything I could find.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@torben-hansen torben-hansen requested a review from a team as a code owner January 13, 2026 15:30
@torben-hansen torben-hansen requested a review from dkostic January 13, 2026 15:32
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.12%. Comparing base (1494e78) to head (b66e18c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2941      +/-   ##
==========================================
- Coverage   78.21%   78.12%   -0.10%     
==========================================
  Files         690      679      -11     
  Lines      118750   117949     -801     
  Branches    16680    16599      -81     
==========================================
- Hits        92881    92142     -739     
+ Misses      24981    24920      -61     
+ Partials      888      887       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@torben-hansen
Copy link
Copy Markdown
Contributor Author

Blocked on aws/s2n-tls#5699

dkostic
dkostic previously approved these changes Jan 14, 2026
jakemas
jakemas previously approved these changes Jan 14, 2026
@torben-hansen torben-hansen dismissed stale reviews from jakemas and dkostic via b87b4b4 January 15, 2026 17:59
justsmth
justsmth previously approved these changes Jan 15, 2026
@torben-hansen torben-hansen merged commit 0b6fb3e into aws:main Jan 15, 2026
396 of 400 checks passed
@torben-hansen torben-hansen deleted the remove_kyber_ref3 branch January 15, 2026 22:35
@justsmth justsmth mentioned this pull request Jan 21, 2026
justsmth added a commit that referenced this pull request Jan 22, 2026
### Description of changes: 
Prepare AWS-LC v1.67.0

#### What's Changed
* Migrate Wycheproof test vectors for ECDSA, RSA PKCS#1, and some more
by @sgmenda in #2887
* increase timeout for SDE tests by @sgmenda in
#2936
* Rename volatile state/memory to unique state/memory by @torben-hansen
in #2935
* Fix failing Windows Docker image build by @nhatnghiho in
#2931
* Service Indicator: Add error call trampoline to avoid delocator issue
by @jakemas in #2920
* Add support for Big Endian in ACVP tool by @samuel40791765 in
#2938
* AES-GCM: Add function pointer trampolines to avoid delocator issue by
@jakemas in #2919
* Use already defined macro for no inline by @torben-hansen in
#2942
* Remove Kyber completely by @torben-hansen in
#2941
* Windows 7 support by @justsmth in
#2940
* Import mldsa-native by @jakemas in
#2902
* Use existing session context if new is actually NULL by @torben-hansen
in #2946
* Integrate Wycheproof ML-KEM test vectors by @sgmenda in
#2891
* Avoid cross-compilation build failure by @justsmth in
#2944


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants