Support stdin for openssl rsa tool#2899
Merged
samuel40791765 merged 4 commits intoaws:mainfrom Dec 11, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
=======================================
Coverage 78.26% 78.26%
=======================================
Files 683 683
Lines 117604 117625 +21
Branches 16515 16514 -1
=======================================
+ Hits 92042 92060 +18
- Misses 24675 24678 +3
Partials 887 887 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
previously approved these changes
Dec 11, 2025
justsmth
previously approved these changes
Dec 11, 2025
skmcgrail
previously approved these changes
Dec 11, 2025
6734ceb
07fb6c1 to
6734ceb
Compare
justsmth
previously approved these changes
Dec 11, 2025
f3cd964 to
24e313c
Compare
justsmth
approved these changes
Dec 11, 2025
skmcgrail
approved these changes
Dec 11, 2025
samuel40791765
added a commit
that referenced
this pull request
Dec 12, 2025
Fix CI failure in #2899 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
P327135637Description of changes:
There are users that expect the stdin format when using the
openssl rsatool. I also noticed a number of behavioral issues/differences while working on this and comparing it to Openssl's version.stdin, sincestdindoesn't have a FILE rewind mechanism. This PR aligns AWS-LC behavior with that.OpenSSL does not fallback to the raw format, but exposes it through aImplemented RSAPublicKey_in as a no-op.RSAPublicKey_inflag. Our fallback here isn't really an issue though, but I left a TODO to implementRSAPublicKey_in. We haven't noticed any actual consumption of such yet.OpenSSL does not support reading the RSAPrivateKey format via the CLI. It's unclear whether this is actually needed in our code. I'm hesitant to remove it though, but I've left some notes to clean this up.OpenSSL's PKCS8 parser falls back to PKCS1 if unsuccessful. We have to do so manually.Call-outs:
N/A
Testing:
New RSA comparison test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.