Add conversion and traceability for third-party test vectors#2839
Merged
Add conversion and traceability for third-party test vectors#2839
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
+ Coverage 78.24% 78.42% +0.17%
==========================================
Files 683 683
Lines 117346 117347 +1
Branches 16488 16492 +4
==========================================
+ Hits 91821 92032 +211
+ Misses 24641 24428 -213
- Partials 884 887 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
approved these changes
Nov 21, 2025
torben-hansen
approved these changes
Nov 21, 2025
sgmenda
added a commit
that referenced
this pull request
Jan 7, 2026
…2887) ### Issues: Migrating Wycheproof test vectors to the new `third_party/vectors/` system introduced in #2811 and extended in #2839, enabling systematic tracking and traceability. ### Description of changes: Migrates 30 test vector files to the new vector system: - 10 ECDSA test files (secp224r1, secp256r1, secp384r1, secp521r1, secp256k1 with SHA-224, SHA-256, SHA-384, SHA-512) - 4 DSA test files (2048-bit and 3072-bit keys with SHA-224, SHA-256) - 1 EdDSA test file (Ed25519) - 12 RSA PKCS#1 signature verification test files (2048, 3072, 4096, 8192-bit keys with SHA-224, SHA-256, SHA-384, SHA-512) - 5 RSA PKCS#1 signature generation test files (1024, 1536, 2048, 3072, 4096-bit keys including weak key sizes) - 3 RSA PKCS#1 v1.5 decryption test files (2048, 3072, 4096-bit keys) Each migration adds upstream JSON vectors and converted txt files to `third_party/vectors/`, updates test files with new paths and duvet annotations for traceability, and removes old files from `third_party/wycheproof_testvectors/`. ### Call-outs: - Previous `rsa_signature_test.txt` superseded by `rsa_signature_*_sha*_test.txt` files with explicit key sizes - Previous `rsa_sig_gen_misc_test.txt` superseded by `rsa_pkcs1_*_sig_gen_test.txt` files with explicit key sizes - Remaining test vectors will be migrated in follow-up PRs ### Testing: All migrated tests pass and duvet verification succeeds: ```bash cd build && ./crypto/crypto_test cd third_party/vectors && python3 sync.py ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses the need to convert third-party test vectors to AWS-LC's file_test.h format and track which vectors are tested. Currently, test vectors are manually converted and there's no systematic way to verify that all vectors in
third_party/are actually used in tests.Description of changes:
Extends the test vector infrastructure from #2811 with two new phases (each can be skipped independently):
convert_vector.py(inspired by the existing Go converter)vectors_spec.mdwith MUST requirements and uses duvet to verify that test files contain corresponding annotationsConverts and integrates
aes_gcm_testfrom the latest upstream Wycheproof as a proof of concept, the test and duvet verification pass.Call-outs:
util/convert_wycheproof/will be removed once all test vectors are migrated to the new systemaes_gcm_testvector inthird_party/wycheproof_testvectors/Testing:
convert_vector.pyverify JSON to file_test.h conversioncrypto/cipher_extra/aead_test.ccRun the full workflow with
cd third_party/vectors && ./sync.py.Run the migrated test with
cd build && ./crypto/crypto_test --gtest_filter="AEADTest.WycheproofAESGCM"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.