Skip to content

Fix GCC 4.8 docker img; Also w/ GCC 7.5#2344

Merged
justsmth merged 1 commit intoaws:mainfrom
justsmth:fix-docker-gcc-4.8
Apr 25, 2025
Merged

Fix GCC 4.8 docker img; Also w/ GCC 7.5#2344
justsmth merged 1 commit intoaws:mainfrom
justsmth:fix-docker-gcc-4.8

Conversation

@justsmth
Copy link
Copy Markdown
Contributor

Description of changes:

  • Fixes broken docker image for GCC 4.8.
    • The same image provide GCC 7.5. I don't see a need for a separate GCC 7.2 image.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner April 21, 2025 20:49
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (a47a334) to head (58d899c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
- Coverage   78.77%   78.75%   -0.02%     
==========================================
  Files         620      620              
  Lines      107954   107954              
  Branches    15336    15328       -8     
==========================================
- Hits        85036    85023      -13     
- Misses      22262    22274      +12     
- Partials      656      657       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth merged commit e6afed9 into aws:main Apr 25, 2025
102 of 106 checks passed
@justsmth justsmth deleted the fix-docker-gcc-4.8 branch April 25, 2025 16:48
@justsmth justsmth mentioned this pull request Apr 30, 2025
justsmth added a commit that referenced this pull request Apr 30, 2025
### Description of changes: 
Bump version to 1.50.1. (Needed so that `aws-lc-sys` can to pick up
latest s2n-bignum changes.)

### Call-outs:
#### What's Changed
* Fix GCC 4.8 docker img; Also w/ GCC 7.5 by @justsmth in
#2344
* Fix LibRdKafka CI by @smittals2 in
#2372
* Expand .clang-tidy configuration by @justsmth in
#2356
* nginx-1.28.0 aws-lc-nginx.patch by @robvanoostenrijk in
#2373
* s2n bignum import method change by @torben-hansen in
#2324
* Fix a theoretical overflow in BIO_printf by @justsmth in
#2369
* Fix tpm2-tss integration test by @justsmth in
#2370


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants