Minor build fixes for CMake and libssl on x86#2267
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2267 +/- ##
==========================================
- Coverage 79.04% 79.04% -0.01%
==========================================
Files 612 612
Lines 106588 106630 +42
Branches 15083 15098 +15
==========================================
+ Hits 84252 84281 +29
- Misses 21684 21696 +12
- Partials 652 653 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
previously approved these changes
Mar 12, 2025
justsmth
approved these changes
Mar 12, 2025
smittals2
approved these changes
Mar 12, 2025
Merged
skmcgrail
added a commit
that referenced
this pull request
Mar 13, 2025
## What's Changed * Use unsigned return type for BN_get_minimal_width and word size tests by @torben-hansen in #2260 * Revert removal of "PEM_X509_INFO_write_bio" by @smittals2 in #2226 * Remove no-op register move from ChaCha20_ctr32_ssse3_4x by @nebeid in #2234 * Fix aws-lc-rs CI test when symbols removed by @justsmth in #2262 * Add x4 batched SHAKE128 and SHAKE256 APIs by @manastasova in #2247 * Fix aws-lc-rs CI test (again) by @justsmth in #2268 * Minor build fixes for CMake and libssl on x86 by @skmcgrail in #2267 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
CMAKE_SYSTEM_PROCESSOR_LOWER. These can result in a failure ifCMAKE_SYSTEM_PROCESSOR_LOWERis an empty string as the${}is expanded first in the if-statement due to historical reasons.libsslcan fail to compile if building on x86 since we don't pass-msse2to the C++ compiler. This is due to the fact that thecrypto/internal.his included by libssl and it explicitly checks for SSE2 support. See https://github.com/aws/aws-lc/blob/main/crypto/internal.h#L203-L214Testing
./util/32-bit-toolchain.cmakethat only sets-m32(since building on an x86-64 platform).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.