Add the rehash utility to the openssl CLI tool#2258
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
========================================
Coverage 79.03% 79.04%
========================================
Files 612 614 +2
Lines 106630 106934 +304
Branches 15097 15143 +46
========================================
+ Hits 84271 84521 +250
- Misses 21707 21761 +54
Partials 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Mar 17, 2025
tool-openssl/c_rehash_test.sh
Outdated
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
|
|
||
| # Run c_rehash with -help | ||
| output=$("${SCRIPT_DIR}/c_rehash" -help 2>&1) |
Contributor
There was a problem hiding this comment.
Shouldn't this be ${SCRIPT_DIR}/c_rehash.sh?
Contributor
Author
There was a problem hiding this comment.
File is renamed when placed into build and install dirs:
https://github.com/aws/aws-lc/pull/2258/files#diff-770a4bd1d030385193d7470f7eef5fead79d759b05f9bd3a9da5a3801fd196b7R49
skmcgrail
reviewed
Mar 17, 2025
justsmth
reviewed
Mar 18, 2025
justsmth
previously approved these changes
Mar 19, 2025
justsmth
approved these changes
Mar 19, 2025
skmcgrail
approved these changes
Mar 19, 2025
Merged
skmcgrail
added a commit
that referenced
this pull request
Mar 28, 2025
## What's Changed * Revert "Allow constructed strings in BER parsing (#2015)" by @samuel40791765 in #2278 * Add the rehash utility to the openssl CLI tool by @smittals2 in #2258 * Documentation on service indicator by @justsmth in #2281 * Update patches in Ruby CI by @samuel40791765 in #2233 * Reject DSA trailing garbage in EVP layer, add test cases by @skmcgrail in #2289 * Add support for verifying PKCS7 signed attributes by @samuel40791765 in #2264 * Add support for more SSL BIO functions by @samuel40791765 in #2273 * Wire-up rust-openssl into GitHub CI (for the time being) by @skmcgrail in #2291 * Adding detection of out-of-bound pre-bound memory read to AES-XTS tests. by @nebeid in #2286 * AES: Add function pointer trampoline to avoid delocator issue by @hanno-becker in #2294 * Bump mysql CI to 9.2.0 by @samuel40791765 in #2161 * Cherrypick hardening DSA param checks from BoringSSL by @smittals2 in #2293 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding the rehash utility to the OpenSSL CLI tool. This design makes a number of different design choices from OpenSSL. Namely:
A wrapper bash script was created to call the openssl rehash functionality. This script is made executable and placed in the install folder via cmake. We also copy a test for this bash script to the build dir.
Testing:
Unit tests for the two tier hashtable and integration tests with symlink generation. Added another test to verify the functionality of the produced c_rehash script.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.