Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
+ Coverage 78.74% 78.76% +0.01%
==========================================
Files 598 598
Lines 103656 103656
Branches 14720 14719 -1
==========================================
+ Hits 81629 81645 +16
+ Misses 21375 21359 -16
Partials 652 652 ☔ View full report in Codecov by Sentry. |
manastasova
reviewed
Jan 7, 2025
WillChilds-Klein
previously approved these changes
Jan 7, 2025
d3d689b to
5e54cda
Compare
WillChilds-Klein
approved these changes
Jan 7, 2025
andrewhop
approved these changes
Jan 7, 2025
justsmth
pushed a commit
that referenced
this pull request
Feb 12, 2025
Note: **Merge after #2177 is merged**. ### Issues: Resolves #CryptoAlg-2826 As part of validating ML-DSA into AWS-LC-FIPS we must include both `PQDSA` and `ML-DSA` directories into the fipsmodule. This PR is a repeat of: - #2095 ### Description of changes: Much like the series of PRs for ML-KEM we will implement the move into the FIPS module across split PRs: - #1828 - #1832 - #1838 Previous PR: - #2166 This PR is part (2) to move `ML-DSA` from `crypto/ml_dsa/` to `crypto/fipsmodule/ml_dsa/`. We did this once before: - #2095 But had to revert it here due to static fips builds for ARM failing in CI (CryptoAlg-2899) - #2104 We are now unblocked by: - #2177 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Move ML-DSA to FIPS module.
ML-DSA is still off by default in the FIPS module. We will be removing the enable_dilithium flag in #2096.
Description of changes:
The following files have been moved from the
crypto/dilithium/directory:p_pqdsa_test.ccmoved toevp_extra/p_pqdsa_test.ccpqcrystals_dilithium_ref_common/moved tofipsmodule/ml_dsa/ml_dsa_ref/ml_dsa.{h/c}moved tofipsmodule/ml_dsa/This is consistant with the
ML-KEMimplementation in the fipsmodule, that has akemfolder (analogous to thepqdsafolder) andml_kemfolder (analogous toml_dsafolder).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.