Skip to content

DH paramgen callback#1928

Merged
justsmth merged 1 commit intoaws:mainfrom
justsmth:DH-paramgen-callback
Oct 22, 2024
Merged

DH paramgen callback#1928
justsmth merged 1 commit intoaws:mainfrom
justsmth:DH-paramgen-callback

Conversation

@justsmth
Copy link
Copy Markdown
Contributor

@justsmth justsmth commented Oct 17, 2024

Issues:

Resolves CryptoAlg-2696

Description of changes:

  • Add support for callbacks in DH paramgen

Call-outs:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth marked this pull request as ready for review October 17, 2024 19:37
@justsmth justsmth requested a review from a team as a code owner October 17, 2024 19:37
@justsmth justsmth force-pushed the DH-paramgen-callback branch from 3bc706a to 721b047 Compare October 17, 2024 19:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 17, 2024

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.69%. Comparing base (04b369f) to head (51957be).
⚠️ Report is 604 commits behind head on main.

Files with missing lines Patch % Lines
crypto/evp_extra/p_dh.c 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   78.68%   78.69%           
=======================================
  Files         585      585           
  Lines      100836   100857   +21     
  Branches    14291    14297    +6     
=======================================
+ Hits        79342    79367   +25     
+ Misses      20858    20856    -2     
+ Partials      636      634    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth enabled auto-merge (squash) October 18, 2024 16:17
@justsmth justsmth merged commit 238f7a9 into aws:main Oct 22, 2024
skmcgrail added a commit that referenced this pull request Nov 7, 2024
## What's Changed
* 800-131Ar1: length of the key-derivation key shall be at least 112
bits. by @skmcgrail in #1924
* Marshalling/Unmarshalling DH public keys by @justsmth in
#1916
* Also prune SSM documents from ec2-test-framework by @samuel40791765 in
#1925
* Use illegal_parameter instead of decode_error for invalid key shares
by @justsmth in #1923
* Add null check in dh testing by @torben-hansen in
#1937
* DH paramgen callback by @justsmth in
#1928
* Upstream merge 2024 10 17 by @torben-hansen in
#1934
* Remove old Intel CPU types by @justsmth in
#1942
* Remove retries on PCT failure in EC and RSA key generation. by @nebeid
in #1938
* Add p4p, bump up time by @justsmth in
#1943
* PQ README by @jakemas in #1932
* bump mysql CI to 9.1.0 by @justsmth in
#1939
* HKDF, HKDF_expand, and PBKDF Truncated SHA2-512 by @skmcgrail in
#1946
* Missing functionality + Adding Nmap to our CI by @smittals2 in
#1915
* Fix FIPS.md typo by @justsmth in
#1950
* Support encode or decode ∞ like OpenSSL by @samuel40791765 in
#1930
* Expand support for EVP_PKEY_HMAC by @justsmth in
#1933
* Add PKCS7-internal BIO_f_cipher by @WillChilds-Klein in
#1836
* Add PKCS7-internal BIO_f_md by @WillChilds-Klein in
#1886
* Ruby Support - DSA custom md by @justsmth in
#1953
* Add support for POINT_CONVERSION_HYBRID by @samuel40791765 in
#1936
* Fixes for Coverity Alerts by @smittals2 in
#1960
* Also test w/ gcc 4.8 by @justsmth in
#1962
* Actually add support for SSL_get_server/peer_tmp_key by
@samuel40791765 in #1945
* Coverity Fix Null Check by @smittals2 in
#1965
* ML-KEM keygen Pairwise Consistency Test by @dkostic in
#1964
* EDDSA PCT by @torben-hansen in #1968
* Expose AES_cfb1_encrypt and AES_cfb8_encrypt by @skmcgrail in
#1967

**Full Changelog**:
v1.37.0...v1.38.0

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants