Actually fix MostRecentProvider reuse bug#105
Merged
mattsb42-aws merged 11 commits intoaws:masterfrom Jan 16, 2019
mattsb42-aws:fixme
Merged
Actually fix MostRecentProvider reuse bug#105mattsb42-aws merged 11 commits intoaws:masterfrom mattsb42-aws:fixme
mattsb42-aws merged 11 commits intoaws:masterfrom
mattsb42-aws:fixme
Conversation
karlw00t
approved these changes
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
After #102 failed to fix the bug that the customer was seeing in cache use, digging into this deeper I found that the
encrypt_ddb_itemfunction was calling.refresh()on the crypto materials provider every pass. That component was not supposed to ever use that interface.Also included here is additional logging since we didn't have much of any in either
MetaStoreorMostRecentProvider.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.