[v2] Update RSA private key size to 2048 in CloudTrail unit test#8903
Merged
[v2] Update RSA private key size to 2048 in CloudTrail unit test#8903
Conversation
This is required to unblock updating our `cryptography` pin: aws#8895 This test was ported 5 years ago as is using a key size of 512: aws#4846 As of `cryptography==43.0.0` the minimum key size allowed is 512: pyca/cryptography@83dcbc1 This change bumps it up to a more reasonable value of 2048. This has only a couple hundredths of a second time difference to generate as tested on my Mac.
|
🐧 |
|
ohh, just now i got that this is " ship it" |
Member
Author
|
I think you're right on both accounts - It's the "ship it squirrel" symbol, and is humorous! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#8895
Description of changes:
This is required to unblock updating our
cryptographypin as a unit test for a CloudTrail customization is failing:#8895
This test was ported 5 years ago as is using a key size of 512:
#4846
As of
cryptography==43.0.0the minimum key size allowed is 1024:pyca/cryptography@83dcbc1
This change bumps it up to a more modern value of 2048. This has only a couple hundredths of a second time difference to generate as tested on my Mac.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.