Replace dependency on rsa with cryptography#4846
Merged
Conversation
kdaily
added a commit
to kdaily/aws-cli
that referenced
this pull request
Sep 6, 2024
This is required to unblock updating our `cryptography` pin: aws#8895 This test was ported 5 years ago as is using a key size of 512: aws#4846 As of `cryptography==43.0.0` the minimum key size allowed is 512: pyca/cryptography@83dcbc1 This change bumps it up to a more reasonable value of 2048. This has only a couple hundredths of a second time difference to generate as tested on my Mac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates all customizations that used the
rsapackage withcryptography. This should be a drop in replacement. The only difference I've noticed is leniency for whitespace in the PEM file (openssldoesn't like whitespace in the middle of the PEM). Tested a local install in edit mode and the binary builds for Windows, Mac, and Linux.