Skip to content

fix: allow colorama upgrade#5712

Closed
greut wants to merge 5 commits intoaws:developfrom
greut:fix/bump-colorama
Closed

fix: allow colorama upgrade#5712
greut wants to merge 5 commits intoaws:developfrom
greut:fix/bump-colorama

Conversation

@greut
Copy link
Copy Markdown
Contributor

@greut greut commented Nov 11, 2020

Description of changes:

awscli can be installed using the latest verison of colorama.

https://github.com/tartley/colorama/releases/tag/0.4.4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@greut
fix: allow colorama upgrade
51840c2 
Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
@kdaily
Copy link
Copy Markdown
Member

kdaily commented Nov 19, 2020

Hi @greut, what's the use case for bumping the version of colorama? Thanks!

@kdaily kdaily added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 19, 2020
@kdaily
Copy link
Copy Markdown
Member

kdaily commented Nov 20, 2020

Hi @greut,

Can you please restrict the ceiling to <=0.4.5 so that when this is released (in pre-release now) we can get that version?

We will double check the changes made up to that version. We also need to check our other builds to see if they need to be changed as well.

Thanks!

@kdaily kdaily added pr:work-in-progress This PR is a draft and needs further work. installation labels Nov 20, 2020
@greut
fixup! fix: allow colorama upgrade
bea9c7e 
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@greut
Copy link
Copy Markdown
Contributor Author

greut commented Nov 20, 2020 •
edited
Loading

what's the use case for bumping the version of colorama? Thanks!

Other projects where @dependabot updates aggressively the version of literally everything.

Code-wise, the changes are very small.

0.4.3...0.4.4

Note that your carefulness is greatly appreciated.

@kdaily kdaily mentioned this pull request Dec 8, 2020
Closed
@greut
Merge remote-tracking branch 'origin/develop' into fix/bump-colorama
28696fa 
Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 10, 2021 •
edited
Loading

Codecov Report

Merging #5712 (28696fa) into develop (ad0829e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5712   +/-   ##
========================================
  Coverage    92.62%   92.62%           
========================================
  Files          203      203           
  Lines        16102    16102           
========================================
  Hits         14915    14915           
  Misses        1187     1187

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0829e...28696fa. Read the comment docs.

@kdaily kdaily mentioned this pull request Mar 19, 2021
Open
@greut
Merge remote-tracking branch 'origin/develop' into fix/bump-colorama
29ba786 
Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
@c0deaddict
Copy link
Copy Markdown

c0deaddict commented Oct 25, 2021 •
edited
Loading

Can this PR be merged? The current version of colorama (<0.4.4) is conflicting with other packages, for instance with https://github.com/sonatype-nexus-community/jake (<0.5.0,>=0.4.4)

@kdaily kdaily removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 30, 2021
pld-gitsync pushed a commit to pld-linux/awscli that referenced this pull request Dec 8, 2021
@jpalus
up to 1.22.21
f23b7ef 
- drop upperbounds of colorama/docutils as they seem to be kept forever
  by upstream... ie colorama PR is more than a year old now:
  aws/aws-cli#5712
@mboboc
Copy link
Copy Markdown

mboboc commented Jan 10, 2022 •
edited
Loading

When is this PR gonna be merged? The current version of colorama (<0.4.4) is conficting with djlint as well.
colorama<0.5.0,>=0.4.4 (from djlint==0.7.1)

@adriananeci
Copy link
Copy Markdown

adriananeci commented Mar 7, 2022

Any updates on this PR? Many other requirements are failing because of this :(

@greut greut mentioned this pull request Mar 12, 2022
Closed
asford added a commit to asford/awscli-feedstock that referenced this pull request Mar 27, 2022
@asford
Build awscli with relaxed colorama pin
37a9160 
Many packages have started to update with colorama 0.4.4,
however this unpin in stalled upstream

aws/aws-cli#5712
aws/aws-cli#6522
@stealthycoin stealthycoin mentioned this pull request Apr 22, 2022
Merged
@stealthycoin
Copy link
Copy Markdown
Contributor

stealthycoin commented Apr 22, 2022

Merged in #6893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

installation pr:work-in-progress This PR is a draft and needs further work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@greut @kdaily @codecov-io @c0deaddict @mboboc @adriananeci @stealthycoin