Append a newline to config files if needed#3139
Merged
joguSD merged 1 commit intoaws:developfrom Apr 14, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3139 +/- ##
===========================================
+ Coverage 97.09% 97.09% +<.01%
===========================================
Files 406 406
Lines 33362 33376 +14
===========================================
+ Hits 32394 32408 +14
Misses 968 968
Continue to review full report at Codecov.
|
Contributor
|
Let's try to get codecov passing. |
e8e41bb to
0a40605
Compare
|
Any reason this hasn't been merged yet? |
|
Ping? |
This was referenced Mar 2, 2021
|
why was it not merged? |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
) (aws#3139) Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com> Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com>
0a40605 to
87cdf0d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3139 +/- ##
========================================
Coverage 92.85% 92.85%
========================================
Files 204 204
Lines 16298 16310 +12
========================================
+ Hits 15133 15145 +12
Misses 1165 1165
Continue to review full report at Codecov.
|
nateprewitt
approved these changes
Apr 14, 2022
87cdf0d to
9a1d9e3
Compare
9a1d9e3 to
4e6fe0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2996
This will check if the config file ends in a newline, if not it appends one before writing a new section to avoid writing an invalid config file. This pretty much only happens on windows.