feat(cli): configurable timeout for ECS hotswap operation #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 79.18% 79.46% +0.28%
==========================================
Files 54 54
Lines 6912 6914 +2
Branches 772 776 +4
==========================================
+ Hits 5473 5494 +21
+ Misses 1421 1400 -21
- Partials 18 20 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
May 8, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
…_VALUE cannot be converted to Integer` (#973) The PR #417 introduced extra hotswap flags. However, when used the flags yield serialisation errors like bellow because the expected type is a number not a string. ``` failed: SerializationException: STRING_VALUE cannot be converted to Integer ``` This PR changes hotswap-ecs-minimum-healthy-percent, hotswap-ecs-maximum-healthy-percent, and hotswap-ecs-stabilization-timeout-seconds from string to expected type number type. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During hotswap deployment, we wait for the ECS service to become stable:
aws-cdk-cli/packages/@aws-cdk/tmp-toolkit-helpers/src/api/hotswap/ecs-services.ts
Lines 153 to 156 in f6bd7b9
The timeout is hardcoded to 600 seconds, which is a very long time to have to wait. This PR add an additional property to the already existing ECS overrides bag, to configure this timeout.
Notes
Our integ tests currently suffer from this because they needlessly wait the hard-coded 10 minute timeout in a test that asserts ECS updates error handling. With this option, we set the operation timeout to 10 seconds and reduce the total integ suite duration from 17min to 9min.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license