Skip to content

feat(secretsmanager): add grantUpdate method#8600

Merged
mergify[bot] merged 7 commits intoaws:masterfrom
ialford:feature/add-grantUpdate-permissions
Jun 30, 2020
Merged

feat(secretsmanager): add grantUpdate method#8600
mergify[bot] merged 7 commits intoaws:masterfrom
ialford:feature/add-grantUpdate-permissions

Conversation

@ialford
Copy link
Copy Markdown
Contributor

@ialford ialford commented Jun 17, 2020 •
edited by skinny85
Loading

This creates the grantUpdate method to give an iam.IGrantable the ability to update a secret in Secrets Manager.

I opted to move it out from the grantWrite method, as there may be cases where we want something to write an initial value, but not change it later on. This decision could be reversed if it seems too granular or too much of an edge-case.

Closes #8491

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

skinny85
skinny85 previously requested changes Jun 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ialford !

Can I propose a slightly different take on this? Can you add 'secretsmanager:UpdateSecret' permission to the existing grantWrite() method, instead of a creating new one?

Thanks,
Adam

@ialford
Copy link
Copy Markdown
Contributor Author

ialford commented Jun 29, 2020

Thanks for the PR @ialford !

Can I propose a slightly different take on this? Can you add 'secretsmanager:UpdateSecret' permission to the existing grantWrite() method, instead of a creating new one?

Thanks,
Adam

Sure, no problem. I wasn't sure which was the better route to take, as I could see use cases for both. I'll push up a revision soon.

@mergify mergify bot dismissed skinny85’s stale review June 30, 2020 13:30

Pull request has been modified.

@ialford
Copy link
Copy Markdown
Contributor Author

ialford commented Jun 30, 2020

@skinny85 ,

I've updated as requested. Feel free to review when able.

skinny85
skinny85 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ialford !

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 30, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ff15172
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4e72d1e into aws:master Jun 30, 2020
@isker isker mentioned this pull request Feb 25, 2022
Merged
mergify bot pushed a commit that referenced this pull request Mar 1, 2022
@isker
docs(secretsmanager): remove reference to Secret.grantUpdate (#19151)
2d6a266 
This method does not exist.  This mention in the docs is leftover from an abandoned approach in #8600 and should have been reverted.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra pushed a commit to TheRealAmazonKendra/aws-cdk that referenced this pull request Mar 11, 2022
@isker @TheRealAmazonKendra
docs(secretsmanager): remove reference to Secret.grantUpdate (aws#19151)
cb8612d 
This method does not exist.  This mention in the docs is leftover from an abandoned approach in aws#8600 and should have been reverted.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skinny85 skinny85 skinny85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skinny85 skinny85

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

secretsmanager grantWrite doesn't give permission to update a secret

3 participants

@ialford @aws-cdk-automation @skinny85