feat(autoscaling): enable group metrics collections#7432
Merged
Conversation
NetaNir
commented
Apr 19, 2020
nija-at
suggested changes
Apr 30, 2020
nija-at
reviewed
Apr 30, 2020
Contributor
nija-at
left a comment
There was a problem hiding this comment.
README needs to be updated as well.
…aws/aws-cdk into neta-eli/autoscaling-metrics-collection
added 2 commits
July 1, 2020 14:41
NetaNir
commented
Jul 1, 2020
nija-at
suggested changes
Jul 2, 2020
packages/@aws-cdk/aws-autoscaling/test/integ.asg-metrics-collections.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-autoscaling/test/test.auto-scaling-group.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-autoscaling/test/test.auto-scaling-group.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-autoscaling/test/test.auto-scaling-group.ts
Outdated
Show resolved
Hide resolved
iliapolo
reviewed
Jul 19, 2020
iliapolo
approved these changes
Jul 20, 2020
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Chriscbr
pushed a commit
to Chriscbr/aws-cdk
that referenced
this pull request
Jul 23, 2020
* feat(autoscaling): add metrics collections Co-authored-by: Neta Nir <neta@amazon.com> Co-authored-by: Eli Polonsky <epolon@amazon.com>
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
* feat(autoscaling): add metrics collections Co-authored-by: Neta Nir <neta@amazon.com> Co-authored-by: Eli Polonsky <epolon@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for MetricsCollection.
See
READMEfor details about the feature and implementationcloses #6453
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license