fix(acm-certificatemanager): DnsValidatedCertificate doesn't wait long enough#7150
Closed
nlang wants to merge 14 commits intoaws:masterfrom
Closed
fix(acm-certificatemanager): DnsValidatedCertificate doesn't wait long enough#7150nlang wants to merge 14 commits intoaws:masterfrom
nlang wants to merge 14 commits intoaws:masterfrom
Conversation
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…g enough fixed test for IAM policy fixes aws#5831
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…g enough fixing test for IAM policy fixes aws#5831
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…g enough updated ref params fixes aws#5831
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…g enough fixing related tests fixes aws#5831
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
Author
|
Hi! Can I help with clarifying things or can we start a discussion about if this is the right way or what can be improved for this PR to get accepted? Thanks a bunch! |
Contributor
Author
|
Any news on this? |
Contributor
|
Apologies for the long wait @nlang . I'll look into this PR. |
jogold
added a commit
to jogold/aws-cdk
that referenced
this pull request
Jun 15, 2020
…icate Automatically adding Amazon Route 53 CNAME records for DNS validation is now natively supported by CloudFormation. Add a `validation` prop to `Certificate` to handle both email and DNS validation. Deprecate `DnsValidatedCertificate`. The default remains email validation (non-breaking). Closes aws#5831 Closes aws#5835 Closes aws#6081 Closes aws#6516 Closes aws#7150 Closes aws#7941 Closes aws#7995 Closes aws#7996
jogold
added a commit
to jogold/aws-cdk
that referenced
this pull request
Jun 15, 2020
…cate Automatically adding Amazon Route 53 CNAME records for DNS validation is now natively supported by CloudFormation. Add a `validation` prop to `Certificate` to handle both email and DNS validation. Deprecate `DnsValidatedCertificate`. The default remains email validation (non-breaking). Closes aws#5831 Closes aws#5835 Closes aws#6081 Closes aws#6516 Closes aws#7150 Closes aws#7941 Closes aws#7995 Closes aws#7996
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2020
…cate (#8552) Automatically adding Amazon Route 53 CNAME records for DNS validation is now natively supported by CloudFormation. Add a `validation` prop to `Certificate` to handle both email and DNS validation. `DnsValidatedCertificate` is now only useful for cross-region certificate creation. The default remains email validation (non-breaking). Closes #5831 Closes #5835 Closes #6081 Closes #6516 Closes #7150 Closes #7941 Closes #7995 Closes #7996 Closes #8282 Closes #8659 Closes #8783 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be considered a quick temporary fix, as it is not the best way to accomplish the longer wait. Best thing would probably be to use the custom resource framework which will use a Cloud Watch scheduled event to call the lambda every 2 minutes until the pending task is successfull or failed.
What I did here is to just let the Lambda call itself and then start another waiter. That's obviously not the most efficient way, but as I said, this is a quick fix that works for that (at least for me) urgent problem arising from the current 9.5 minute wait time maximum.
Any thoughts, comments or improvement suggestions are highly welcome.
Commit Message
fix(acm-certificatemanager): DnsValidatedCertificate doesn't wait long enough
fixes #5831
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license