Skip to content

feat(cognito): user pool - MFA, password policy and email settings#6717

Merged
mergify[bot] merged 12 commits intomasterfrom
nija-at/cognito-security-emails
Mar 17, 2020
Merged

feat(cognito): user pool - MFA, password policy and email settings#6717
mergify[bot] merged 12 commits intomasterfrom
nija-at/cognito-security-emails

Conversation

@nija-at
Copy link
Contributor

@nija-at nija-at commented Mar 13, 2020 •
edited
Loading

Commit Message

feat(cognito): user pool - MFA, password policy and email settings (#6717)

Add support in user pool for configuring MFA, password policy and
settings for transmitted emails.

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

feat(cognito): user pool - MFA, password policy and email settings
de90875 
Add support in user pool for configuring MFA, password policy and
settings for transmitted emails.
@nija-at nija-at added the contribution/core This is a PR that came from AWS. label Mar 13, 2020
@nija-at nija-at requested a review from a team March 13, 2020 17:07
@nija-at nija-at self-assigned this Mar 13, 2020
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 13, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: de90875
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

CaerusKaru
CaerusKaru reviewed Mar 13, 2020
View reviewed changes
eladb
eladb reviewed Mar 16, 2020
View reviewed changes
@nija-at nija-at requested a review from eladb March 17, 2020 13:04
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 013a416
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 24fb3cf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb added the pr/do-not-merge This PR should not be merged at this time. label Mar 17, 2020
eladb
eladb reviewed Mar 17, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Added "do-not-merge"

packages/@aws-cdk/aws-cognito/README.md
```ts
new UserPool(this, 'myuserpool', {
// ...
emailTransmission: {
Copy link
Contributor

@eladb eladb Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe emailOption?

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 27a1636
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Mar 17, 2020
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a5c4388
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a42c051
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at closed this Mar 17, 2020
@nija-at nija-at reopened this Mar 17, 2020
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 63e4d11
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b1f00de
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: df26df8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cc35dad into master Mar 17, 2020
@mergify mergify bot deleted the nija-at/cognito-security-emails branch March 17, 2020 20:15
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ed32aa0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@snyk-bot snyk-bot mentioned this pull request Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@CaerusKaru CaerusKaru CaerusKaru left review comments

@eladb eladb eladb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nija-at nija-at

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nija-at @aws-cdk-automation @CaerusKaru @eladb