Skip to content

fix(cli): update bit.ly link to be directly to github#3782

Merged
shivlaks merged 3 commits intoaws:masterfrom
alsmola:patch-1
Aug 26, 2019
Merged

fix(cli): update bit.ly link to be directly to github#3782
shivlaks merged 3 commits intoaws:masterfrom
alsmola:patch-1

Conversation

@alsmola
Copy link
Copy Markdown
Contributor

@alsmola alsmola commented Aug 25, 2019

The http://bit.ly link seems suspicious. At least make it https, or better yet link directly to the issue.

Update http://bit.ly/cdk-2EhF7Np => #1299

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@alsmola
Update bit.ly link to be directly to Github
cb4119f 
The http://bit.ly link seems suspicious. At least make it `https`, or better yet link directly to the issue.
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 25, 2019 •
edited by shivlaks
Loading

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

eladb
eladb previously approved these changes Aug 26, 2019
View reviewed changes
@eladb eladb changed the title Update bit.ly link to be directly to Github chore(cli): update bit.ly link to be directly to Github Aug 26, 2019
@eladb eladb changed the title chore(cli): update bit.ly link to be directly to Github fix(cli): update bit.ly link to be directly to Github Aug 26, 2019
@eladb eladb changed the title fix(cli): update bit.ly link to be directly to Github fix(cli): update bit.ly link to be directly to github Aug 26, 2019
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 26, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot dismissed eladb’s stale review August 26, 2019 12:11

Pull request has been modified.

@shivlaks
Copy link
Copy Markdown
Contributor

shivlaks commented Aug 26, 2019

I agree, it's more transparent and clean to get this link updated.
@alsmola Thanks for your contribution!

@shivlaks shivlaks merged commit 042fb53 into aws:master Aug 26, 2019
@rhboyd
Copy link
Copy Markdown
Contributor

rhboyd commented Sep 9, 2019

I think this is making the CLI Integration test fail. The change was made in the test but doesn't seem to be in CDK

aws-cdk/packages/@aws-cdk/cloudformation-diff/lib/format.ts

Line 69 in f827a88

formatter.warning(`(NOTE: There may be security-related changes not in this list. See http://bit.ly/cdk-2EhF7Np)`);

@rix0rrr
Copy link
Copy Markdown
Contributor

rix0rrr commented Sep 23, 2019

Yep, well spotted. Fixing it now.

rix0rrr added a commit that referenced this pull request Sep 23, 2019
@rix0rrr
chore: fix CLI integration tests
ee90fba 
Fix breakage introduced by #3782, which changed the wrong string.

Update other expectation to match change introduced in #3772.
@rix0rrr rix0rrr mentioned this pull request Sep 23, 2019
Merged
mergify bot pushed a commit that referenced this pull request Sep 24, 2019
@rix0rrr @mergify
chore: fix CLI integration tests (#4198)
7ce8112 
* chore: fix CLI integration tests

Fix breakage introduced by #3782, which changed the wrong string.

Update other expectation to match change introduced in #3772.

* Use substitutions in error message

* Rewrite how CLI tests are being run

* Extract environment setup from tests

* Need to not ignore integ test Javascript files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shivlaks shivlaks shivlaks approved these changes

@eladb eladb eladb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@shivlaks shivlaks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alsmola @shivlaks @rhboyd @rix0rrr @eladb