Skip to content

fix(core): intrinsic cfn function tokens are not detected as such in java#36843

Merged
mergify[bot] merged 2 commits intomainfrom
epolon/bump-pacmak
Feb 3, 2026
Merged

fix(core): intrinsic cfn function tokens are not detected as such in java#36843
mergify[bot] merged 2 commits intomainfrom
epolon/bump-pacmak

Conversation

@iliapolo
Copy link
Copy Markdown
Contributor

@iliapolo iliapolo commented Feb 2, 2026

Issue # (if applicable)

Closes #36832

Reason for this change

To fix the bug mentioned in the issue...

Description of changes

Bump the version jsii-pacmak to pull in the jsii fix.

Describe any new or updated permissions being added

None

Description of how you validated changes

No code changes.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 2, 2026 23:52
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p0 labels Feb 2, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 2, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@iliapolo iliapolo changed the title fix(core): intrinsic cfn function tokens are not detected as such fix(core): intrinsic cfn function tokens are not detected as such in java Feb 3, 2026
@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Feb 3, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 3, 2026 10:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2026

Merge Queue Status

✅ The pull request has been merged at fee2f72

This pull request spent 29 minutes 5 seconds in the queue, including 28 minutes 56 seconds running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3f29f11 into main Feb 3, 2026
17 of 18 checks passed
@mergify mergify bot deleted the epolon/bump-pacmak branch February 3, 2026 10:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p0 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

certificatemanager: Conditions in domainName are being rejected because their string representation is > 64 characters

4 participants