Skip to content

feat(pipelines): CodeBuildFactory support Docker server#35584

Merged
ozelalisen merged 2 commits intoaws:mainfrom
phuhung273:codebuild-factory-dockerserver
Sep 26, 2025
Merged

feat(pipelines): CodeBuildFactory support Docker server#35584
ozelalisen merged 2 commits intoaws:mainfrom
phuhung273:codebuild-factory-dockerserver

Conversation

@phuhung273
Copy link
Copy Markdown
Contributor

@phuhung273 phuhung273 commented Sep 26, 2025

Issue # (if applicable)

Closes #35562

Reason for this change

CodeBuildFactory support Docker server

Description of changes

CodeBuildFactory support Docker server

Description of how you validated changes

Unit + Integ

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 26, 2025 05:08
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 26, 2025
ozelalisen
ozelalisen previously approved these changes Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the queued label Sep 26, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ozelalisen ozelalisen self-assigned this Sep 26, 2025
mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify
Merge of #35584
fbd2485
@mergify mergify bot mentioned this pull request Sep 26, 2025
Closed
30 tasks
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #35584 has been manually updated.

You can check the last failing draft PR here: #35593.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Sep 26, 2025
@mergify mergify bot dismissed ozelalisen’s stale review September 26, 2025 12:37

Pull request has been modified.

@ozelalisen
Copy link
Copy Markdown
Member

ozelalisen commented Sep 26, 2025

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 26, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot added the queued label Sep 26, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify
Merge of #35584
386004f
@mergify mergify bot mentioned this pull request Sep 26, 2025
Closed
30 tasks
@ozelalisen ozelalisen merged commit c62d996 into aws:main Sep 26, 2025
31 of 33 checks passed
@mergify mergify bot removed the queued label Sep 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 26, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2025
@phuhung273 phuhung273 deleted the codebuild-factory-dockerserver branch September 26, 2025 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ozelalisen ozelalisen ozelalisen approved these changes

Assignees

@ozelalisen ozelalisen

Labels

bug This issue is a bug. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-codebuild)(pipelines) DockerServer property dropped when using _build_env in CDK Pipelines CodeBuild projects

2 participants

@phuhung273 @ozelalisen