Skip to content

fix(core): Tag must have a value error is impossible to attribute to a specific tag#35091

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
ryan-pol:add-tag-value-to-error
Jul 29, 2025
Merged

fix(core): Tag must have a value error is impossible to attribute to a specific tag#35091
mergify[bot] merged 6 commits intoaws:mainfrom
ryan-pol:add-tag-value-to-error

Conversation

@ryan-pol
Copy link
Copy Markdown
Contributor

Issue # (if applicable)

Not applicable

Reason for this change

Make it clearer as to what tag has invalid values - currently the process to identify said tag is not as clear as it could be.

Description of changes

Improve error message from Tag must have a value to Tag '${key}' must have a value

Describe any new or updated permissions being added

Not applicable

Description of how you validated changes

Test added

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ryan-pol ryan-pol requested a review from a team as a code owner July 28, 2025 16:19
@github-actions github-actions bot added the p2 label Jul 28, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 28, 2025 16:19
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 28, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 28, 2025
@mrgrain mrgrain changed the title chore: include key name for undefined tag value error fix(core): undefined tag value error does not include key Jul 29, 2025
@mrgrain mrgrain changed the title fix(core): undefined tag value error does not include key fix(core): Tag must have a value error is impossible to attribute to a specific tag Jul 29, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 29, 2025
mrgrain
mrgrain previously approved these changes Jul 29, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 29, 2025 10:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 29, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35091 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "build" is in progress.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@ryan-pol
Copy link
Copy Markdown
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission >= write

@mergify mergify bot dismissed mrgrain’s stale review July 29, 2025 11:23

Pull request has been modified.

@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Jul 29, 2025

@ryan-pol Thanks for the contribution. As you are a first time contributor, getting this merged is a little more complex. But don't worry about it, I'll take care of it. Please do not touch the PR anymore, it will just complicate things even further. Specifically no need to update your branch. Thanks again.

@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Jul 29, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

update

☑️ Nothing to do, the required conditions are not met

Details
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 813dd72
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35091 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "build" is in progress.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Jul 29, 2025

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 6c4181b into aws:main Jul 29, 2025
20 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants