fix(custom-resources): use loggingFormat instead of deprecated logFormat by pahud · Pull Request #35015 · aws/aws-cdk

pahud · 2025-07-19T03:51:05Z

Use loggingFormat instead of deprecated logFormat in the Provider class

Issue # (if applicable)

Reason for this change

The logFormat property in Lambda Function is deprecated and will be removed in the next major release. This change updates the Provider class to use the recommended loggingFormat property instead, eliminating deprecation warnings.

Description of changes

Updated the Provider class in provider.ts to use loggingFormat instead of the deprecated logFormat property
Added a test in provider.test.ts to verify that no deprecation warnings are emitted when creating a Provider
Ensured backward compatibility by maintaining the same functionality

This change is minimal and focused on replacing the deprecated property with its recommended alternative. The functionality remains the same, but the code now follows best practices and avoids deprecation warnings.

Describe any new or updated permissions being added

No new or updated IAM permissions are needed for this change.

Description of how you validated changes

Added a unit test that verifies no deprecation warnings are emitted when using the Provider class
Manually verified that the Provider class still functions correctly with the new property
Ensured backward compatibility by testing with existing code

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mergify · 2025-07-28T15:46:19Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-07-28T15:46:23Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Abogical · 2025-07-28T15:54:54Z

@Mergifyio rebase

mergify · 2025-07-28T15:55:40Z

rebase

✅ Branch has been successfully rebased

mergify · 2025-07-28T16:24:49Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-07-28T16:28:32Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Abogical · 2025-07-29T07:08:02Z

@Mergifyio rebase

Use loggingFormat instead of deprecated logFormat in the Provider class to avoid deprecation warnings. Added a test to verify that no deprecation warnings are emitted.

mergify · 2025-07-29T07:08:49Z

rebase

✅ Branch has been successfully rebased

mergify · 2025-07-29T07:35:17Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-07-29T07:41:15Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35015 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "build" is failing.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Abogical · 2025-07-29T07:42:57Z

@Mergifyio requeue

mergify · 2025-07-29T07:43:07Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-07-29T09:06:11Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35015 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "build" is queued.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Abogical · 2025-07-29T09:38:18Z

@Mergifyio requeue

mergify · 2025-07-29T09:38:54Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-07-29T10:08:23Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-07-29T10:10:37Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: fbde231
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

github-actions · 2025-07-29T10:11:14Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team July 19, 2025 03:51

github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Jul 19, 2025

mergify bot added the contribution/core This is a PR that came from AWS. label Jul 19, 2025

pahud marked this pull request as ready for review July 19, 2025 04:39

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 23, 2025

Abogical self-assigned this Jul 28, 2025

Abogical changed the title ~~chore(custom-resources): use loggingFormat instead of deprecated logFormat~~ fix(custom-resources): use loggingFormat instead of deprecated logFormat Jul 28, 2025

Abogical added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 28, 2025

Abogical approved these changes Jul 28, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 28, 2025

Abogical force-pushed the fix-35002-custom-resource-logging-format branch from 42c085b to 4ad27f2 Compare July 28, 2025 15:55

pahud added 2 commits July 29, 2025 07:08

fix(custom-resources): use loggingFormat instead of deprecated logFormat

19ddbe1

Use loggingFormat instead of deprecated logFormat in the Provider class to avoid deprecation warnings. Added a test to verify that no deprecation warnings are emitted.

docs: add comment explaining loggingFormat usage

997f0c9

Abogical force-pushed the fix-35002-custom-resource-logging-format branch from 4ad27f2 to 997f0c9 Compare July 29, 2025 07:08

Merge branch 'main' into fix-35002-custom-resource-logging-format

fbde231

Abogical mentioned this pull request Jul 29, 2025

fix(provider): use the correct log format property in provider framework #35092

Closed

1 task

mergify bot merged commit 81fe660 into aws:main Jul 29, 2025
20 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2025

Conversation

pahud commented Jul 19, 2025

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

mergify bot commented Jul 28, 2025

Uh oh!

mergify bot commented Jul 28, 2025

Uh oh!

Abogical commented Jul 28, 2025

Uh oh!

mergify bot commented Jul 28, 2025

✅ Branch has been successfully rebased

Uh oh!

mergify bot commented Jul 28, 2025

Uh oh!

mergify bot commented Jul 28, 2025

Uh oh!

Abogical commented Jul 29, 2025

Uh oh!

mergify bot commented Jul 29, 2025

✅ Branch has been successfully rebased

Uh oh!

mergify bot commented Jul 29, 2025

Uh oh!

mergify bot commented Jul 29, 2025

Uh oh!

Abogical commented Jul 29, 2025

Uh oh!

mergify bot commented Jul 29, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Jul 29, 2025

Uh oh!

Abogical commented Jul 29, 2025

Uh oh!

mergify bot commented Jul 29, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Jul 29, 2025

Uh oh!

aws-cdk-automation commented Jul 29, 2025

AWS CodeBuild CI Report

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants