fix(eks-v2-alpha): ensure kubectl provider access entry is depended upon by downstream resources#34898
Closed
fix(eks-v2-alpha): ensure kubectl provider access entry is depended upon by downstream resources#34898
Conversation
…pon by downstream resources
aws-cdk-automation
previously requested changes
Jul 3, 2025
Contributor
Author
|
Exemption Request: no functional change. simple dependency ordering can be tested via unit tests |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
1 task
Member
|
Integ tests currently don't support testing deletions. Will exempt this from integ tests. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
This was referenced Jan 13, 2026
Abogical
requested changes
Jan 14, 2026
Member
Abogical
left a comment
There was a problem hiding this comment.
I've reproduced the issue and confirmed that this patch fixes the issue. Nice job!
Snapshots however needs to be updated as it currently conflicts with the main branch.
1 task
mergify bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…pon by downstream resources (#36734) _Note: Copied from #34898 with updated snapshots, credit to @msessa._ Closes #34897 ### Reason for this change The `AccessEntry` for kubectl provider should be included as a dependency of the kubectl ready barrier. ### Description of changes Add the kubectl `AccessEntry` to the explicit dependencies for the ready barrier resource ### Description of how you validated changes - Updated unit test - Updated integration tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Member
|
Closing in favor of #36734. This is the same patch but with updated snapshots. |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #34897
Reason for this change
The
AccessEntryfor kubectl provider should be included as a dependency of the kubectl ready barrier.Description of changes
Add the kubectl
AccessEntryto the explicit dependencies for the ready barrier resourceDescription of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license