Skip to content

feat(dsql-alpha): initial L2 construct#34599

Open
msambol wants to merge 18 commits intoaws:mainfrom
msambol:34593
Open

feat(dsql-alpha): initial L2 construct#34599
msambol wants to merge 18 commits intoaws:mainfrom
msambol:34593

Conversation

@msambol
Copy link
Copy Markdown
Contributor

@msambol msambol commented Jun 1, 2025 •
edited
Loading

Adds a new L2 construct for Amazon Aurora DSQL.

Closes #34593

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Jun 1, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 1, 2025 02:37
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 1, 2025
@msambol msambol changed the title feat(dsql): initial L2 construct feat(dsql-alpha): initial L2 construct Jun 1, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 1, 2025
badmintoncryer
badmintoncryer reviewed Jun 20, 2025
View reviewed changes
mazyu36
mazyu36 suggested changes Jun 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
Some minor comments.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 20, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cf21d46
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Jun 25, 2025

@mazyu36 Mind taking another look here?

mazyu36
mazyu36 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

badmintoncryer
badmintoncryer approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great work!

@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Closed
@badmintoncryer
Copy link
Copy Markdown
Contributor

badmintoncryer commented Aug 15, 2025

@msambol Could you please merge main branch? The needs-maintainer-review label has not added yet.

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Aug 15, 2025

@badmintoncryer can you try approving again?

@badmintoncryer badmintoncryer mentioned this pull request Aug 19, 2025
Closed
1 task
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Sep 11, 2025

@badmintoncryer could you try to approve this again so it gets the maintainer label please?

@badmintoncryer
Copy link
Copy Markdown
Contributor

badmintoncryer commented Sep 12, 2025

I've approved again! However, it seems that you need to yarn install again.

Error: ERROR! Dependency @aws-cdk/integ-runner@^2.186.11 from @aws-cdk/aws-dsql-alpha not present in yarn.lock. Please run 'yarn install' and try again!
    at errorIfNotInYarnLock (/codebuild/output/src3210664793/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:45:13)
    at /codebuild/output/src3210664793/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:50:80
    at Array.forEach (<anonymous>)
    at /codebuild/output/src3210664793/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:50:45
    at Array.forEach (<anonymous>)
    at main (/codebuild/output/src3210664793/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:49:12)

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Sep 12, 2025

I've approved again! However, it seems that you need to yarn install again.

Error: ERROR! Dependency @aws-cdk/integ-runner@^2.186.11 from @aws-cdk/aws-dsql-alpha not present in yarn.lock. Please run 'yarn install' and try again!
    at errorIfNotInYarnLock (/codebuild/output/src3210664793/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:45:13)
    at /codebuild/output/src3210664793/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:50:80
    at Array.forEach (<anonymous>)
    at /codebuild/output/src3210664793/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:50:45
    at Array.forEach (<anonymous>)
    at main (/codebuild/output/src3210664793/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:49:12)

Hmm when I do that it changes a lot of other things in yarn.lock ?

@badmintoncryer
Copy link
Copy Markdown
Contributor

badmintoncryer commented Dec 14, 2025

@msambol Could you please resolve build error ? This feature is treated as p1 now.

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Dec 14, 2025

@msambol Could you please resolve build error ? This feature is treated as p1 now.

Yes, will do.

@pahud pahud mentioned this pull request Dec 14, 2025
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2025 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

TestsPassed ✅SkippedFailed
Security Guardian Results48 ran48 passed
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2025 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates48 ran48 passed
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation added pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 14, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 2, 2026
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Apr 2, 2026

@vishaalmehrishi Updated with your feedback. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishaalmehrishi vishaalmehrishi vishaalmehrishi left review comments

+2 more reviewers

@mazyu36 mazyu36 mazyu36 approved these changes

@badmintoncryer badmintoncryer badmintoncryer approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@vishaalmehrishi vishaalmehrishi

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2 pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dsql: L2 constructs for Aurora DSQL

6 participants

@msambol @aws-cdk-automation @badmintoncryer @vishaalmehrishi @mazyu36 @Abogical