Skip to content

feat(synthetics): add maxRetries prop to configure automatic retries on canary runs#34541

Merged
mergify[bot] merged 11 commits intoaws:mainfrom
georeeve:canary-automatic-retries
Jul 7, 2025
Merged

feat(synthetics): add maxRetries prop to configure automatic retries on canary runs#34541
mergify[bot] merged 11 commits intoaws:mainfrom
georeeve:canary-automatic-retries

Conversation

@georeeve
Copy link
Copy Markdown
Contributor

@georeeve georeeve commented May 23, 2025

Issue # (if applicable)

Closes #34511.

Reason for this change

Adds support for configuring automatic retries of Canary runs.

Description of changes

This adds a maxRetries property on the top-level of the CanaryProps interface. It uses this to configure the retryConfig structure on the schedule structure. This works similarly to how the timeToLive property configures the durationInSeconds field on the schedule structure.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

I have updated the unit and integ tests, and have deployed manually, and verified the changes in the AWS console.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 23, 2025 12:43
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels May 23, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes May 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review May 23, 2025 12:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation
aws-cdk-automation previously requested changes May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@georeeve
Copy link
Copy Markdown
Contributor Author

georeeve commented May 27, 2025

Clarification Request

I've updated the integ test, but I'm running into an error when trying to run it. I'm getting the following error:
ZipAsset (ZipAssetA028C65F) Resource handler returned message: "Could not unzip uploaded file. Please check your file, then try to upload again. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID:; Proxy: null)" (RequestToken:, HandlerErrorCode: GeneralServiceException)

I'm running yarn integ-runner --directory test/aws-synthetics/test/ --update-on-failed --parallel-regions eu-west-1 from the packages/@aws-cdk-testing/framework-integ directory. Am I perhaps running it from the wrong directory so it can't find the zip file? Or is the zip file failing for some other reason? I'd appreciate any advice on this!

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label May 27, 2025
@georeeve
Copy link
Copy Markdown
Contributor Author

georeeve commented May 27, 2025

Looks like the same integ errors were encountered in #34254 which @badmintoncryer managed to resolve. I can try and regenerate the snapshots but it does seem a bit flaky.

@georeeve
Copy link
Copy Markdown
Contributor Author

georeeve commented May 27, 2025

I seem to have gotten around the zip issue, but I'm now getting Synthetics runtime version syn-nodejs-puppeteer-7.0 does not support Auto Retry which makes sense as only v10+ supports auto retries. Unfortunately I think that means we're blocked until #34241 is merged in unless we want to use an escape hatch to override the runtime in the integ test for now (I suspect not)?

badmintoncryer
badmintoncryer suggested changes May 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! After your modification, I'll execute integ test later.

@github-actions github-actions bot mentioned this pull request Jun 1, 2025
Closed
@aemada-aws aemada-aws assigned aemada-aws and unassigned aemada-aws Jun 3, 2025
@aemada-aws aemada-aws self-assigned this Jun 17, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 6, 2025 15:46

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 7, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7249498
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 54d8a84 into aws:main Jul 7, 2025
18 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2025
@georeeve georeeve deleted the canary-automatic-retries branch July 7, 2025 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aemada-aws aemada-aws aemada-aws approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

@badmintoncryer badmintoncryer Awaiting requested review from badmintoncryer

Assignees

@aemada-aws aemada-aws

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-synthetics): Add support for configuring automatic retries of Canary runs

5 participants

@georeeve @aws-cdk-automation @badmintoncryer @aemada-aws @Abogical