feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime by pv-rudger · Pull Request #34241 · aws/aws-cdk

pv-rudger · 2025-04-24T13:12:53Z

Issue # (if applicable)

Closes #34240.

Reason for this change

Runtime versions using Node.js and Puppeteer confirms that Synthetics runtime syn-nodejs-puppeteer-10.0 is available.

Description of changes

Added syn-nodejs-puppeteer-10.0 as supported runtime.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

I have updated some tests, containing the same runtime with the new version.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…#34240) Closes aws#34240. [Runtime versions using Node.js and Puppeteer](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html) confirms that Synthetics runtime `syn-nodejs-puppeteer-10.0` is available. Added `syn-nodejs-puppeteer-10.0` as supported runtime. N/A - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…ejs-puppeteer-10.0

aws-cdk-automation

(This review is outdated)

mazyu36

Thank you for the contribution.
I've added one comment.

packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts

mazyu36 · 2025-04-24T16:21:43Z

Also could you add an integ test for 10.0?

aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.ts

Line 104 in 15791d7

    
           const puppeteer91 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_9_1);

@mazyu36

thank you @mazyu36

Could only use with dry-run, because it required access to the actual environment? comand used: yarn integ aws-synthetics/test/integ.canary.js --update-on-failed --dry-run

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

…ejs-puppeteer-10.0

pv-rudger · 2025-05-03T19:59:01Z

Also could you add an integ test for 10.0?

aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.ts

Line 104 in 15791d7

const puppeteer91 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_9_1);

@mazyu36 Can you validate if this is done correct?

mazyu36

Thanks!

aws-cdk-automation · 2025-05-08T00:12:29Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2025-05-09T00:12:13Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

pv-rudger · 2025-05-09T07:35:07Z

I have fixed the merge conflicts, but it will be difficult to maintain without a review

pv-rudger · 2025-05-09T07:38:06Z

Can you review this?

@aws/aws-cdk-core-team

aws-cdk-automation · 2025-05-18T00:13:34Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2025-05-19T00:13:36Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2025-06-10T00:12:39Z

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

Resume work on the PR
OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

aws-cdk-automation · 2025-07-03T12:56:49Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 8fd264e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aemada-aws · 2025-07-07T15:12:13Z

Hi @pv-rudger. Thank you for the contribution. The PR looks good to go but PR build is failing because a snapshot is failing, do you have time to update it? Otherwise, I can take over the PR.

aws-cdk-automation · 2025-07-25T00:13:37Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

Resume work on the PR
OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

ROMBORAMA · 2025-08-07T15:21:58Z

Hi @pv-rudger. Thank you for the contribution. The PR looks good to go but PR build is failing because a snapshot is failing, do you have time to update it? Otherwise, I can take over the PR.

@aemada-aws Is this something that you can take over to update the failing snapshot if @pv-rudger is unavailable? Conscious that this PR will close soon if no action is taken.

aws-cdk-automation · 2025-08-08T00:13:38Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

github-actions · 2025-08-08T00:13:49Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team April 24, 2025 13:13

github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Apr 24, 2025

Merge remote-tracking branch 'upstream/main' into feat-synthetics-nod…

15791d7

…ejs-puppeteer-10.0

aws-cdk-automation previously requested changes Apr 24, 2025

View reviewed changes

ykethan mentioned this pull request Apr 24, 2025

aws-synthetics: support syn-nodejs-puppeteer-10.0 runtime #34240

Open

2 tasks

mazyu36 suggested changes Apr 24, 2025

View reviewed changes

packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts Show resolved Hide resolved

pv-rudger added 3 commits April 27, 2025 16:00

Resolve review comment.

45d69dd

thank you @mazyu36

Update readme and tests according to the "aws-cdk-automation" comments

e0b10d1

Update Integration Canary Test

108c226

github-actions bot mentioned this pull request May 1, 2025

Monthly PR metrics report #34324

Closed

Update snapshot, with 'yarn integ --update-on-failed --dry-run'

0d442d5

Could only use with dry-run, because it required access to the actual environment? comand used: yarn integ aws-synthetics/test/integ.canary.js --update-on-failed --dry-run

Merge remote-tracking branch 'upstream/main' into feat-synthetics-nod…

9368e46

…ejs-puppeteer-10.0

mazyu36 approved these changes May 4, 2025

View reviewed changes

Merge branch 'main' into feat-synthetics-nodejs-puppeteer-10.0

8bd4275

Merge branch 'main' into feat-synthetics-nodejs-puppeteer-10.0

641dbf4

georeeve mentioned this pull request May 27, 2025

feat(synthetics): add maxRetries prop to configure automatic retries on canary runs #34541

Merged

1 task

aemada-aws self-assigned this Jun 3, 2025

pv-rudger and others added 2 commits June 23, 2025 10:23

Merge branch 'main' into feat-synthetics-nodejs-puppeteer-10.0

9d77687

Merge branch 'main' into feat-synthetics-nodejs-puppeteer-10.0

8fd264e

aemada-aws approved these changes Jul 3, 2025

View reviewed changes

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Aug 8, 2025

aws-cdk-automation closed this Aug 8, 2025

github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2025

Conversation

pv-rudger commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mazyu36 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mazyu36 commented Apr 24, 2025

Uh oh!

pv-rudger commented May 3, 2025

Uh oh!

mazyu36 left a comment

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented May 8, 2025

Uh oh!

aws-cdk-automation commented May 9, 2025

Uh oh!

pv-rudger commented May 9, 2025

Uh oh!

pv-rudger commented May 9, 2025

Uh oh!

aws-cdk-automation commented May 18, 2025

Uh oh!

aws-cdk-automation commented May 19, 2025

Uh oh!

aws-cdk-automation commented Jun 10, 2025

Uh oh!

aws-cdk-automation commented Jul 3, 2025

AWS CodeBuild CI Report

Uh oh!

aemada-aws commented Jul 7, 2025

Uh oh!

aws-cdk-automation commented Jul 25, 2025

Uh oh!

ROMBORAMA commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aws-cdk-automation commented Aug 8, 2025

Uh oh!

github-actions bot commented Aug 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pv-rudger commented Apr 24, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

ROMBORAMA commented Aug 7, 2025 •

edited

Loading