chore: npm-check-updates && yarn upgrade#34378
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34378 +/- ##
=======================================
Coverage 83.99% 83.99%
=======================================
Files 121 121
Lines 6934 6934
Branches 1164 1164
=======================================
Hits 5824 5824
Misses 999 999
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
c792936 to
907bdd7
Compare
|
Comments on closed issues and PRs are hard for our team to see. |
|
Following integ tests failed: It is due to the recommended value of the aws/aws-cdk-cli@4bd6149#diff-cc2aa6328f725cd5a81d9ded74633857d38594c65a715e3411b80ec52ca5cdacR68
Edit: I changed my direction. I noticed that many snapshots were impacted due to the recommended value change. Instead of going through each integ test to set the the FF explicitly, I decided to upgrade the |
### Issue # (if applicable) N/A ### Reason for this change The integ tests changed in this PR are failing the yarn upgrade job: #34378 This is because recommended value of the `createNewPoliciesWithAddToRolePolicy` feature flag changed in the `integ-runner` package: aws/aws-cdk-cli@4bd6149#diff-cc2aa6328f725cd5a81d9ded74633857d38594c65a715e3411b80ec52ca5cdacR68 So making this PR specifically for upgrading `@aws-cdk/integ-runner` and updating the snapshots required by it. ### Description of changes Upgraded `@aws-cdk/integ-runner`, then updated the snapshots ### Description of how you validated changes There is no actual code change to CDK constructs. Checked the snapshots and see expected changes resulted from feature flag value being changed. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
c397e66 to
1b32bec
Compare
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
1b32bec to
bbe6cbb
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Ran npm-check-updates and yarn upgrade to keep the
yarn.lockfile up-to-date.