feat(events): add arnForPolicy attribute for api destination#34315
feat(events): add arnForPolicy attribute for api destination#34315mergify[bot] merged 20 commits intoaws:mainfrom
arnForPolicy attribute for api destination#34315Conversation
| * @see https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazoneventbridge.html#amazoneventbridge-resources-for-iam-policies | ||
| * @attribute | ||
| */ | ||
| readonly apiDestinationArnForPolicy?: string; |
There was a problem hiding this comment.
Considering the existence of users who are using IApiDestination, I made the definition optional to avoid breaking changes.
Pull request has been modified.
|
@QuantumNeuralCoder Could you please confirm this PR again? |
|
@mergify update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
@ozelalisen Could you please approve this again ? |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: Pull request #34315 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.). You can check the last failing draft PR here: #34939. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: Pull request #34315 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.). You can check the last failing draft PR here: #34954. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
@mergify update |
✅ Branch has been successfully updated |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
L1 construct has
arnForPolicyattribute but L2 construct does not support this.https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-apidestination.html#aws-resource-events-apidestination-return-values#aws-resource-events-apidestination-return-values-fn--getatt
Description of changes
apiDestinationArnForPolicytoApiDestinationAttributesand attribute ofIApiDestinationDescribe any new or updated permissions being added
None
Description of how you validated changes
Add both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license