Merged
Conversation
0cbd80b to
c7bb559
Compare
aws-cdk-automation
previously requested changes
Feb 17, 2025
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
pushed a commit
to aws/aws-cdk-cli
that referenced
this pull request
Feb 17, 2025
This adds code from the original repositories, moving it here as announced in aws/aws-cdk#32775. The PR that removes the original code: aws/aws-cdk#33474
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33474 +/- ##
==========================================
+ Coverage 81.00% 82.16% +1.16%
==========================================
Files 238 119 -119
Lines 14271 6857 -7414
Branches 2492 1157 -1335
==========================================
- Hits 11560 5634 -5926
+ Misses 2425 1120 -1305
+ Partials 286 103 -183
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mrgrain
approved these changes
Feb 18, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the code of the CLI and CLI-related packages. Those are being moved to a different repository, as announced in #32775
The PR that adds them is here: aws/aws-cdk-cli#37
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license