feat(ses): configurationset support default event bus and firehose as destination by phuhung273 · Pull Request #33093 · aws/aws-cdk

phuhung273 · 2025-01-23T12:33:37Z

Issue # (if applicable)

Closes #32835
Closes #30671

Reason for this change

ConfigurationSet doesn't support EventBridge, Firehose as destination

Description of changes

ConfigurationSet destination support:

Firehose
default EventBus

Description of how you validated changes

Unit + integration

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

codecov · 2025-01-30T01:57:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (0379878) to head (3130f0e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33093   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         119      119           
  Lines        6857     6857           
  Branches     1157     1157           
=======================================
  Hits         5634     5634           
  Misses       1120     1120           
  Partials      103      103

Flag	Coverage Δ
suite.unit	`82.16% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`82.16% <ø> (ø)`

lpizzinidev

Thanks for the PR 👍 Left a comment to discuss the implementation.
Also, are you planning to add the Firehose destination as well?

packages/aws-cdk-lib/aws-ses/lib/configuration-set-event-destination.ts

phuhung273 · 2025-02-03T14:35:39Z

I want to add Firehose also but I simply dont know how :(

Since there is no helper interface and Firehose still not have L2 construct, Im thinking about adding another interface like this CloudWatch

aws-cdk/packages/aws-cdk-lib/aws-ses/lib/configuration-set-event-destination.ts

Lines 165 to 182 in af44791

    
           export interface CloudWatchDimension { 
        
             /** 
        
              * The place where Amazon SES finds the value of a dimension to publish to 
        
              * Amazon CloudWatch. 
        
              */ 
        
             readonly source: CloudWatchDimensionSource; 
        
             /** 
        
              * The name of an Amazon CloudWatch dimension associated with an email sending metric. 
        
              */ 
        
             readonly name: string; 
        
             /** 
        
              * The default value of the dimension that is published to Amazon CloudWatch 
        
              * if you do not provide the value of the dimension when you send an email. 
        
              */ 
        
             readonly defaultValue: string; 
        
           }

Can you help suggest @lpizzinidev ? If yes I will try to include Firehose also.

lpizzinidev

I want to add Firehose also but I simply dont know how :(

DeliveryStream V2 was merged a few days ago.
You should be able to implement it using the construct.

packages/aws-cdk-lib/aws-ses/lib/configuration-set-event-destination.ts

packages/aws-cdk-lib/aws-ses/test/configuration-set-event-destination.test.ts

packages/aws-cdk-lib/aws-ses/README.md

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

phuhung273 · 2025-02-09T17:23:12Z

DeliveryStream V2 was merged a few days ago. You should be able to implement it using the construct.

Thanks for the good news, Firehose added.

packages/aws-cdk-lib/aws-ses/lib/configuration-set-event-destination.ts

aws-cdk-automation

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Thanks 👍

phuhung273 · 2025-02-18T02:49:36Z

Thanks for your review @lpizzinidev 👍

GavinZZ

LGTM, thank you!

mergify · 2025-02-18T22:27:28Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-18T22:31:24Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-18T22:47:12Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

GavinZZ · 2025-02-18T23:07:46Z

@Mergifyio requeue

mergify · 2025-02-18T23:07:53Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-02-18T23:20:38Z

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #33093 has been manually updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Pull request has been modified.

mergify · 2025-02-18T23:50:43Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-02-19T08:14:08Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 3130f0e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-02-19T08:14:11Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-02-19T08:14:23Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(ses): configurationset support default event bus as destination

fe9268c

github-actions bot added the p2 label Jan 23, 2025

aws-cdk-automation requested a review from a team January 23, 2025 12:33

github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Jan 23, 2025

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 23, 2025

Merge branch 'main' into config-set-default-event-bus

a73ca48

github-actions bot mentioned this pull request Feb 1, 2025

Monthly PR metrics report #33266

Closed

lpizzinidev suggested changes Feb 2, 2025

View reviewed changes

packages/aws-cdk-lib/aws-ses/lib/configuration-set-event-destination.ts Outdated Show resolved Hide resolved

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 2, 2025

extend event bus scope

23434fb

fix README

ac7db21

phuhung273 requested a review from lpizzinidev February 4, 2025 15:20

lpizzinidev suggested changes Feb 8, 2025

View reviewed changes

phuhung273 and others added 3 commits February 9, 2025 08:38

Merge branch 'main' into config-set-default-event-bus

c0f689c

Update packages/aws-cdk-lib/aws-ses/README.md

236b308

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

add firehose

388addc

github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels Feb 9, 2025

phuhung273 changed the title ~~feat(ses): configurationset support default event bus as destination~~ feat(ses): configurationset support default event bus and firehose as destination Feb 9, 2025

phuhung273 added 2 commits February 9, 2025 15:59

fix README

352a233

fix README

892c47b

phuhung273 requested a review from lpizzinidev February 9, 2025 17:23

lpizzinidev suggested changes Feb 10, 2025

View reviewed changes

packages/aws-cdk-lib/aws-ses/lib/configuration-set-event-destination.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-ses/lib/configuration-set-event-destination.ts Outdated Show resolved Hide resolved

phuhung273 force-pushed the config-set-default-event-bus branch from d45ffff to 892c47b Compare February 11, 2025 15:40

phuhung273 added 2 commits February 13, 2025 14:28

use interface instead of ARN

ff2f539

fix README

62f4307

aws-cdk-automation previously requested changes Feb 13, 2025

View reviewed changes

Merge branch 'main' into config-set-default-event-bus

f58af9b

phuhung273 requested a review from lpizzinidev February 14, 2025 01:11

lpizzinidev approved these changes Feb 17, 2025

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 17, 2025

GavinZZ previously approved these changes Feb 18, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 18, 2025

GavinZZ self-assigned this Feb 18, 2025

Merge branch 'main' into config-set-default-event-bus

844aa7b

GavinZZ approved these changes Feb 18, 2025

View reviewed changes

Merge branch 'main' into config-set-default-event-bus

3130f0e

mergify bot merged commit d8b0da7 into aws:main Feb 19, 2025
21 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025

phuhung273 deleted the config-set-default-event-bus branch February 19, 2025 08:25

Conversation

phuhung273 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

codecov bot commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phuhung273 commented Feb 3, 2025

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phuhung273 commented Feb 9, 2025

Uh oh!

Uh oh!

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

phuhung273 commented Feb 18, 2025

Uh oh!

GavinZZ left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 18, 2025

Uh oh!

mergify bot commented Feb 18, 2025

Uh oh!

mergify bot commented Feb 18, 2025

Uh oh!

GavinZZ commented Feb 18, 2025

Uh oh!

mergify bot commented Feb 18, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Feb 18, 2025

Uh oh!

mergify bot commented Feb 18, 2025

Uh oh!

aws-cdk-automation commented Feb 19, 2025

AWS CodeBuild CI Report

Uh oh!

Uh oh!

mergify bot commented Feb 19, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

phuhung273 commented Jan 23, 2025 •

edited

Loading

codecov bot commented Jan 30, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading