Skip to content

chore: correct comment syntax in PR template for IAM permissions#32793

Merged
mergify[bot] merged 9 commits intoaws:mainfrom
mazyu36:chore/fix-PR-format
Jan 12, 2025
Merged

chore: correct comment syntax in PR template for IAM permissions#32793
mergify[bot] merged 9 commits intoaws:mainfrom
mazyu36:chore/fix-PR-format

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Jan 8, 2025

The comment regarding IAM permissions was not properly commented out.
So I've fixed.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 8, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 8, 2025 06:56
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jan 8, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 8, 2025
kaizencc
kaizencc previously approved these changes Jan 8, 2025
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 8, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaizencc
Copy link
Copy Markdown
Contributor

kaizencc commented Jan 8, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 8, 2025

update

☑️ Nothing to do

Details
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@kaizencc
Copy link
Copy Markdown
Contributor

kaizencc commented Jan 9, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 9, 2025

update

✅ Branch has been successfully updated

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (a2e0d44) to head (c7cce37).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32793   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         222      222           
  Lines       13695    13695           
  Branches     2412     2412           
=======================================
  Hits        11145    11145           
  Misses       2271     2271           
  Partials      279      279
Flag Coverage Δ
suite.unit 81.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.69% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Jan 9, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 9, 2025

update

☑️ Nothing to do

Details
  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Jan 9, 2025

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 9, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission >= write

@moelasmar moelasmar closed this Jan 9, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 9, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32793 has been dequeued, merge conditions unmatch:

  • -closed
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of [🛡 GitHub branch protection]:
    • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = validate-pr
    • check-skipped = validate-pr
    • check-success = validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-neutral = codecov/patch/packages/aws-cdk
    • check-skipped = codecov/patch/packages/aws-cdk
    • check-success = codecov/patch/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-neutral = codecov/project/packages/aws-cdk
    • check-skipped = codecov/project/packages/aws-cdk
    • check-success = codecov/project/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-neutral = codecov/patch/packages/aws-cdk-lib/core
    • check-skipped = codecov/patch/packages/aws-cdk-lib/core
    • check-success = codecov/patch/packages/aws-cdk-lib/core
  • any of [🛡 GitHub branch protection]:
    • check-neutral = codecov/project/packages/aws-cdk-lib/core
    • check-skipped = codecov/project/packages/aws-cdk-lib/core
    • check-success = codecov/project/packages/aws-cdk-lib/core
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge|no-squash)
  • -merged
  • -title~=(WIP|wip)
  • base!=release

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@moelasmar moelasmar reopened this Jan 9, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
@aws aws unlocked this conversation Jan 9, 2025
@mergify mergify bot dismissed kaizencc’s stale review January 9, 2025 11:58

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 9, 2025
@moelasmar
Copy link
Copy Markdown
Contributor

moelasmar commented Jan 9, 2025

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 9, 2025

refresh

✅ Pull request refreshed

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Jan 10, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 10, 2025

update

✅ Branch has been successfully updated

@moelasmar
Copy link
Copy Markdown
Contributor

moelasmar commented Jan 12, 2025

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 12, 2025

refresh

✅ Pull request refreshed

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 12, 2025
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 12, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c7cce37
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f3b0feb into aws:main Jan 12, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
@mazyu36 mazyu36 deleted the chore/fix-PR-format branch January 12, 2025 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc left review comments

+1 more reviewer

@moelasmar moelasmar moelasmar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mazyu36 @kaizencc @moelasmar @aws-cdk-automation