feat(service-catalog): allow Product Stack to override analytics reporting and stack descriptions#31985
Conversation
…rting and stack descriptions
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
paulhcsun
left a comment
There was a problem hiding this comment.
One small docstring change. I think this should be a feat instead of a chore as well.
|
@Mergifyio update |
☑️ Nothing to doDetails
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31924
Reason for this change
Product Stack cannot override analytics reporting and descriptions. Support these two props.
Description of changes
The reason I didn't choose to allow ProductStackProps to extend StackProps and instead manually add these two properties are because all of the other properties, i.e.
stackName,env,notificationArns,terminationProtection,crossRegionReferences,permissionsBoundary,suppressTemplateIndentation, do not mutate the stack template but are used by CDK CLI. These properties have no impact on the Product Stack template generated and thus I did not include them.Description of how you validated changes
Unit and integ tests added.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license