-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ProductStackProps should extend StackProps #31924
Copy link
Copy link
Closed
Labels
effort/mediumMedium work item – several days of effortMedium work item – several days of effortfeature-requestA feature should be added or improved.A feature should be added or improved.p2package/toolsRelated to AWS CDK Tools or CLIRelated to AWS CDK Tools or CLI
Description
Describe the bug
ProductStack does not allow configuration of the underlying stack template for stack level configuration. This means you can't disable things like analyticsReporting on the stack template that the ProductStack generates. ProductStack constructor currently takes ProductStackProps which doesn't extend the base level StackProps even though ProductStack extends Stack Since CDK::AWS::METADATA resource type does not exist in GovCloud, this means a Stack with a StackSet that references a ProductStack cannot be deployed to GovCloud.
Regression Issue
- Select this option if this issue appears to be a regression.
Last Known Working CDK Version
No response
Expected Behavior
Being able to configure the Stack template that is generated by a ProductStack
Current Behavior
ProductStack doesn't allow configuring stack level options for how it synthesizes its stack templates.
Reproduction Steps
readonly templateFile: string;
private _parentProductStackHistory?;
private _templateUrl?;
private _parentStack;
private assetBucket?;
constructor(scope: Construct, id: string, props?: **ProductStackProps**);```
### Possible Solution
_No response_
### Additional Information/Context
_No response_
### CDK CLI Version
2.164.1
### Framework Version
_No response_
### Node.js Version
node22
### OS
n/a
### Language
TypeScript
### Language Version
_No response_
### Other information
_No response_
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
effort/mediumMedium work item – several days of effortMedium work item – several days of effortfeature-requestA feature should be added or improved.A feature should be added or improved.p2package/toolsRelated to AWS CDK Tools or CLIRelated to AWS CDK Tools or CLI