feat(pipes-targets): add API Gateway#31954
Conversation
|
@Leo10Gama Got another one for you :) This was first reviewed in #30772, but was closed because of inactivity/merge conflicts. |
5249ea2 to
db15170
Compare
db15170 to
4709a1c
Compare
Leo10Gama
left a comment
There was a problem hiding this comment.
Looks pretty good! Because of some of the policy permissions, I'm adding in the needs-security-review label as well, and review with security to verify the changes are OK. Other than that, one comment about how we're verifying the integ test.
Leo10Gama
left a comment
There was a problem hiding this comment.
Changes look good, thanks again for the contribution!
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
|
@Leo10Gama mind re-approving this one? looks like the merge dismissed your review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31954 +/- ##
=======================================
Coverage 77.46% 77.46%
=======================================
Files 105 105
Lines 7168 7168
Branches 1314 1314
=======================================
Hits 5553 5553
Misses 1433 1433
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Add API Gateway REST API as a Pipes target.
Original PR with community review from @nmussy: #30772