feat(pipes-targets): add API Gateway by msambol · Pull Request #30772 · aws/aws-cdk

msambol · 2024-07-06T23:41:00Z

Add API Gateway REST API as a Pipes target.

nmussy

The docs don't explicitly mention that the target can only be a REST API, it might work with WebSockets? If that's the case, could you add an integ and the likes?

packages/@aws-cdk/aws-pipes-targets-alpha/README.md

packages/@aws-cdk/aws-pipes-targets-alpha/lib/api-gateway.ts

packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.api-gateway.ts

msambol · 2024-07-07T14:28:25Z

The docs don't explicitly mention that the target can only be a REST API, it might work with WebSockets? If that's the case, could you add an integ and the likes?

Good shout about the docs. I did create a WebSocket API and it wasn't available in the Console when I tried to create a Pipe target. The CFN docs do state only REST APIs. @redwheeler3, can you confirm if REST APIs are the only type supported here?

packages/@aws-cdk/aws-pipes-targets-alpha/test/api-gateway.test.ts

msambol · 2024-07-07T21:43:23Z

packages/@aws-cdk/aws-pipes-targets-alpha/lib/api-gateway.ts

+  grantPush(grantee: IRole): void {
+    grantee.addToPrincipalPolicy(new PolicyStatement({
+      resources: [this.restApiArn],
+      actions: ['execute-api:Invoke'],


@nmussy updated this to just Invoke

msambol · 2024-07-07T21:44:16Z

packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.api-gateway.ts

+      'x-header': 'myheader',
+    },
+    queryStringParameters: { key: 'USA' },
+    pathParameterValues: ['fiction'],


@nmussy I think this is what you're after? fiction replaces the * in path defined above. More coverage..

redwheeler3 · 2024-07-08T17:20:49Z

Good shout about the docs. I did create a WebSocket API and it wasn't available in the Console when I tried to create a Pipe target. The CFN docs do state only REST APIs. @redwheeler3, can you confirm if REST APIs are the only type supported here?

Pipes does not support WebSocket APIs.

msambol · 2024-07-08T17:22:18Z

Good shout about the docs. I did create a WebSocket API and it wasn't available in the Console when I tried to create a Pipe target. The CFN docs do state only REST APIs. @redwheeler3, can you confirm if REST APIs are the only type supported here?

Pipes does not support WebSocket APIs.

The ManageConnections permission can be removed from the role created by the Console.

aws-cdk-automation · 2024-09-29T00:12:08Z

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation · 2024-09-29T20:27:23Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 78b663c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2024-10-07T00:11:35Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-10-13T00:11:51Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-10-14T00:11:20Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-10-15T00:10:55Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-10-21T00:11:23Z

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation · 2024-10-28T00:11:48Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

github-actions · 2024-10-28T00:12:11Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

github-actions bot added the p2 label Jul 6, 2024

aws-cdk-automation requested a review from a team July 6, 2024 23:41

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jul 6, 2024

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2024

nmussy suggested changes Jul 7, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2024

msambol commented Jul 7, 2024

View reviewed changes

packages/@aws-cdk/aws-pipes-targets-alpha/test/api-gateway.test.ts Show resolved Hide resolved

msambol commented Jul 7, 2024

View reviewed changes

github-actions bot mentioned this pull request Jul 8, 2024

Weekly PR metrics report #30783

Closed

msambol force-pushed the pipes-targets-api-gw branch 2 times, most recently from a254134 to a253bc6 Compare July 10, 2024 15:48

pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024

pahud added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 22, 2024

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 22, 2024

github-actions bot mentioned this pull request Aug 1, 2024

Monthly PR metrics report #30999

Closed

msambol added 7 commits September 29, 2024 11:40

feat(pipes-targets): add API Gateway

0f8ff90

Add feedback from @nmussy

8168162

Update integration test

19abbf2

Fix unit test

5ae77a9

Throw error if API has no deployment stage

0b40f76

Trigger build

71405f9

Update integration test to use SqsSource

2645f76

msambol force-pushed the pipes-targets-api-gw branch from 81cc179 to 2645f76 Compare September 29, 2024 19:23

fix readme

78b663c

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Oct 28, 2024

aws-cdk-automation closed this Oct 28, 2024

github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024

Conversation

msambol commented Jul 6, 2024

Uh oh!

nmussy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msambol commented Jul 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

msambol Jul 7, 2024

Choose a reason for hiding this comment

Uh oh!

msambol Jul 7, 2024

Choose a reason for hiding this comment

Uh oh!

redwheeler3 commented Jul 8, 2024

Uh oh!

msambol commented Jul 8, 2024

Uh oh!

aws-cdk-automation commented Sep 29, 2024

Uh oh!

aws-cdk-automation commented Sep 29, 2024

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 7, 2024

Uh oh!

aws-cdk-automation commented Oct 13, 2024

Uh oh!

aws-cdk-automation commented Oct 14, 2024

Uh oh!

aws-cdk-automation commented Oct 15, 2024

Uh oh!

aws-cdk-automation commented Oct 21, 2024

Uh oh!

aws-cdk-automation commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

msambol commented Jul 7, 2024 •

edited

Loading