fix(lambda-nodejs): breaking change in esbuild causes import module error#30726
fix(lambda-nodejs): breaking change in esbuild causes import module error#30726mergify[bot] merged 8 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Co-authored-by: Momo Kornher <mail@moritzkornher.de>
This reverts commit 2f44737.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
scanlonp
left a comment
There was a problem hiding this comment.
Not sure what is going on with the tree.json changes. The code changes look good.
| "fqn": "aws-cdk-lib.Resource", | ||
| "version": "0.0.0" |
There was a problem hiding this comment.
Are these supposed to be changing like this? Are these updates that should have happened but are only being found now?
There was a problem hiding this comment.
Unrelated, but these haven't been updated in a while so it's likely as a result of the jsii changes that were merged recently. I expected some of this.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…rror (#30726) ### Issue # (if applicable) Closes #30717. ### Reason for this change esbuild introduced a breaking change in v0.22 which caused the build error in `aws-lambda-nodejs` module. ### Description of changes Pin the esbuild version to 0.21 in Dockerfile ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #30717.
Reason for this change
esbuild introduced a breaking change in v0.22 which caused the build error in
aws-lambda-nodejsmodule.Description of changes
Pin the esbuild version to 0.21 in Dockerfile
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license