fix(globalaccelerator-endpoints): add preserveClientIp option for net…#30346
fix(globalaccelerator-endpoints): add preserveClientIp option for net…#30346mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
be3c0fd to
e85316e
Compare
…work loadbalancer ### Issue # (if applicable) ### Reason for this change preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer. ### Description of changes * add missing network load balancer endpoint prop. ### Description of how you validated changes Added integration tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
e85316e to
a88c711
Compare
scorbiere
left a comment
There was a problem hiding this comment.
Thank you for your contribution. Would you mind updating the default value in the comment? Then I can approve the PR.
| * Client IP address preservation is supported only in specific AWS Regions. | ||
| * See the GlobalAccelerator Developer Guide for a list. | ||
| * | ||
| * @default true if available |
There was a problem hiding this comment.
According to the documentation, my understanding is that the default value is false :
https://docs.aws.amazon.com/global-accelerator/latest/dg/preserve-client-ip-address.html
When you add an Network Load Balancer with security groups as an endpoint in Global Accelerator, client IP address preservation is not enabled by default.
| * @default true if available | |
| * @default false |
…work loadbalancer preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer. * add missing network load balancer endpoint prop. Added integration tests. - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@scorbiere thanks, updated the doc. |
scorbiere
left a comment
There was a problem hiding this comment.
LGTM, thanks for the update.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@mergify update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
scorbiere
left a comment
There was a problem hiding this comment.
Re-approving after updating the branch.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws#30346) …work loadbalancer ### Issue # (if applicable) ### Reason for this change preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer. ### Description of changes * add missing network load balancer endpoint prop. ### Description of how you validated changes Added unit tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
aws#30346) …work loadbalancer ### Issue # (if applicable) ### Reason for this change preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer. ### Description of changes * add missing network load balancer endpoint prop. ### Description of how you validated changes Added unit tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
…work loadbalancer
Issue # (if applicable)
Reason for this change
preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer.
Description of changes
Description of how you validated changes
Added unit tests.
Checklist