Skip to content

revert: "fix(diff): properties from ChangeSet diff were ignored"#30243

Merged
mergify[bot] merged 3 commits intomainfrom
revert-30241-fix
May 16, 2024
Merged

revert: "fix(diff): properties from ChangeSet diff were ignored"#30243
mergify[bot] merged 3 commits intomainfrom
revert-30241-fix

Conversation

@SankyRed
Copy link
Copy Markdown
Contributor

@SankyRed SankyRed commented May 16, 2024

Reverts: 30093

@aws-cdk-automation aws-cdk-automation requested a review from a team May 16, 2024 19:48
@github-actions github-actions bot added the p2 label May 16, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 16, 2024
@SankyRed SankyRed temporarily deployed to test-pipeline May 16, 2024 19:49 — with GitHub Actions Inactive
@SankyRed SankyRed added the pr/needs-cli-test-run This PR needs CLI tests run against it. label May 16, 2024
@SankyRed SankyRed temporarily deployed to test-pipeline May 16, 2024 20:03 — with GitHub Actions Inactive
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@SankyRed SankyRed temporarily deployed to test-pipeline May 16, 2024 20:34 — with GitHub Actions Inactive
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 16, 2024

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@mergify mergify bot had a problem deploying to test-pipeline May 16, 2024 20:59 Failure
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 16, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8fbc563
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 811e224 into main May 16, 2024
@mergify mergify bot deleted the revert-30241-fix branch May 16, 2024 21:27
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@colifran colifran mentioned this pull request May 16, 2024
Closed
SankyRed added a commit that referenced this pull request May 17, 2024
@SankyRed
revert: "fix(diff): properties from ChangeSet diff were ignored" (#30243
3748472 
)

Reverts: [30093](#30093)
@github-actions github-actions bot mentioned this pull request May 20, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
@NOUIY NOUIY mentioned this pull request Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this pull request Jun 13, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 14, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 20, 2024
Closed
@NOUIY NOUIY mentioned this pull request Jun 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 21, 2024
Open
This was referenced Jun 22, 2024
Open
Open
This was referenced Jul 5, 2024
Open
Open
This was referenced Jul 16, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request Jul 23, 2024
Open
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 25, 2024

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bergjaak bergjaak bergjaak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-cli-test-run This PR needs CLI tests run against it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SankyRed @aws-cdk-automation @bergjaak