feat(neptune): add copyTagsToSnapshot property to the DatabaseCluster Construct#30092
feat(neptune): add copyTagsToSnapshot property to the DatabaseCluster Construct#30092mergify[bot] merged 7 commits intoaws:mainfrom
Conversation
go-to-k
left a comment
There was a problem hiding this comment.
Thanks for this PR. I just made minor comments.
| const cluster = new neptune.DatabaseCluster(this, 'Database', { | ||
| vpc, | ||
| instanceType: neptune.InstanceType.R5_LARGE, | ||
| copyTagsToSnapshot: true // whether to save the cluster tags when creating the snapshot. |
There was a problem hiding this comment.
It seems unnatural to have this property here, which is the most basic chapter. How about creating a new chapter like the Automatic minor version upgrades?
There was a problem hiding this comment.
I added a new chapter about copyTagsSnapshot.
|
|
||
| const app = new cdk.App(); | ||
|
|
||
| const stack = new cdk.Stack(app, 'aws-cdk-neptune-integ'); |
There was a problem hiding this comment.
It would be good to change the stack name so that the integ test can be deployed in parallel with other tests.
There was a problem hiding this comment.
I changed the stack name.
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
|
@go-to-k |
go-to-k
left a comment
There was a problem hiding this comment.
Thanks for your changes. Looks good!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
… Construct (aws#30092) ### Issue # (if applicable) Closes aws#30087 ### Reason for this change As described in the issue. ### Description of changes Add copyTagsToSnapshot property to the DatabaseCluster Construct. ### Description of how you validated changes Add both unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #30087
Reason for this change
As described in the issue.
Description of changes
Add copyTagsToSnapshot property to the DatabaseCluster Construct.
Description of how you validated changes
Add both unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license