Skip to content

feat(elasticloadbalancingv2): client keepalive for ALB#29504

Merged
mergify[bot] merged 11 commits intoaws:mainfrom
badmintoncryer:keepAlve
Mar 22, 2024
Merged

feat(elasticloadbalancingv2): client keepalive for ALB#29504
mergify[bot] merged 11 commits intoaws:mainfrom
badmintoncryer:keepAlve

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Mar 15, 2024 •
edited
Loading

Issue # (if applicable)

Closes #29503.

Reason for this change

ALB supports configuring client keepalive duration but AWS CDK cannot do that.

Description of changes

Add clientKeepAlive properties to ApplicationLoadBalancerProps.

      new elbv2.ApplicationLoadBalancer(stack, 'LB', {
        vpc,
        clientKeepAlive: Duration.seconds(250),
      });

Description of how you validated changes

I've added both integ and unit tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Mar 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 15, 2024 05:25
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 15, 2024 05:45

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer marked this pull request as ready for review March 15, 2024 05:58
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 15, 2024
lpizzinidev
lpizzinidev suggested changes Mar 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Left some suggestions for minor adjustments

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 15, 2024
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Mar 15, 2024

@lpizzinidev Thank you for your review! I have adderssed your comments.

lpizzinidev
lpizzinidev approved these changes Mar 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 16, 2024
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Closed
@shikha372 shikha372 self-assigned this Mar 18, 2024
GavinZZ
GavinZZ previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 18, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Mar 19, 2024

@GavinZZ Thank you for your review!
Mergify job seems to be failed. Could you please resolve it?

@mergify mergify bot dismissed GavinZZ’s stale review March 20, 2024 03:05

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 20, 2024
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Mar 20, 2024

@GavinZZ I have resolved conflict. Could you please re-review this?

@shikha372 shikha372 removed their assignment Mar 21, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 21, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Mar 22, 2024

@GavinZZ Why does this Mergify job fail? Is there something wrong with how I create my PR?

@GavinZZ
Copy link
Copy Markdown
Member

GavinZZ commented Mar 22, 2024

I'm unsure either, will monitor this PR and see the latest error if it happens again.

@GavinZZ GavinZZ self-assigned this Mar 22, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 22, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 49c1768
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9b79f94 into aws:main Mar 22, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Mar 23, 2024

@GavinZZ Thanks!

jun1-t pushed a commit to jun1-t/aws-cdk that referenced this pull request Mar 23, 2024
@badmintoncryer @jun1-t
feat(elasticloadbalancingv2): client keepalive for ALB (aws#29504)
6be44d0 
### Issue # (if applicable)

Closes aws#29503.

### Reason for this change

[ALB supports configuring client keepalive duration](https://aws.amazon.com/jp/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/) but AWS CDK cannot do that.

### Description of changes

Add `clientKeepAlive` properties to `ApplicationLoadBalancerProps`.

```ts
      new elbv2.ApplicationLoadBalancer(stack, 'LB', {
        vpc,
        clientKeepAlive: Duration.seconds(250),
      });
```

### Description of how you validated changes

I've added both integ and unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@badmintoncryer badmintoncryer deleted the keepAlve branch March 25, 2024 05:41
ahammond pushed a commit to ahammond/aws-cdk that referenced this pull request Mar 26, 2024
@badmintoncryer @ahammond
feat(elasticloadbalancingv2): client keepalive for ALB (aws#29504)
db411a4 
### Issue # (if applicable)

Closes aws#29503.

### Reason for this change

[ALB supports configuring client keepalive duration](https://aws.amazon.com/jp/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/) but AWS CDK cannot do that.

### Description of changes

Add `clientKeepAlive` properties to `ApplicationLoadBalancerProps`.

```ts
      new elbv2.ApplicationLoadBalancer(stack, 'LB', {
        vpc,
        clientKeepAlive: Duration.seconds(250),
      });
```

### Description of how you validated changes

I've added both integ and unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+2 more reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GavinZZ GavinZZ

Labels

feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

elasticloadbalancingv2: client keep alive

5 participants

@badmintoncryer @GavinZZ @aws-cdk-automation @lpizzinidev @shikha372