chore(ec2): update WindowsVersions enum#29435
Conversation
|
I'd accidentally removed some of the previous enum values, I restored them and made sure I didn't miss any: $ git checkout chore-ec2-windows-versions
$ grep -i '^ WINDOWS' lib/windows-versions.ts | sort > new_versions
$ git checkout main
$ grep -i '^ WINDOWS' lib/windows-versions.ts | sort > old_versions
$ diff old_versions new_versions | grep -i '^<' |
| WINDOWS_SERVER_2019_ENGLISH_CORE_BASE_2024_01_16 = 'Windows_Server-2019-English-Core-Base-2024.01.16', | ||
| WINDOWS_SERVER_2019_ENGLISH_CORE_BASE_2024_02_14 = 'Windows_Server-2019-English-Core-Base-2024.02.14', | ||
| /** @deprecated */ | ||
| /** @deprecated - no longer supported */ |
There was a problem hiding this comment.
Not sure why or when Windows_Server-2019-English-Core-ContainersLatest and Windows_Server-2019-English-Full-ContainersLatest were removed, see Windows AMI version history, but they are unavaialble:
$ aws ec2 describe-images --owners amazon --filters 'Name=name,Values=Windows_Server-2019-English-Core-ContainersLatest'
{
"Images": []
}
$ aws ec2 describe-images --owners amazon --filters 'Name=name,Values=Windows_Server-2019-English-Full-ContainersLatest'
{
"Images": []
}| WINDOWS_SERVER_2019_ENGLISH_FULL_BASE_2024_01_16 = 'Windows_Server-2019-English-Full-Base-2024.01.16', | ||
| WINDOWS_SERVER_2019_ENGLISH_FULL_BASE_2024_02_14 = 'Windows_Server-2019-English-Full-Base-2024.02.14', | ||
| /** @deprecated */ | ||
| /** @deprecated - no longer supported */ |
|
What Region did you use? us-east-1? Could there be any differences by Region? |
|
@msambol Yes, I'm using |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
That is... so many. Thanks for taking the time to get these added!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Could not find any in the backlog
Reason for this change
Update the CDK EC2 listed Windows versions to match the current availability
Description of changes
Description of how you validated changes
Once again, I'm comparing the CDK enumeration to live SDK data, this time using the
ec2:DescribeImagesAPI command, with the following parameters:Images that are no longer listed by this command are marked as
@deprecated, and new images are added to the enumChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license