feat(cloudfront-origin): adding FunctionUrlOrigin by watany-dev · Pull Request #29101 · aws/aws-cdk

watany-dev · 2024-02-14T10:16:53Z

Reason for this change

origins.httpOrigin requires a trick to specify the Lambda Functions URL.

Description of changes

This eases that pain and simplifies integration.

Description of how you validated changes

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

colifran · 2024-02-15T23:02:22Z

packages/aws-cdk-lib/aws-cloudfront-origins/lib/function-url-origin.ts

+export interface FunctionUrlOriginProps extends cloudfront.OriginProps {
+  /**
+   * Specifies how long, in seconds, CloudFront waits for a response from the origin.
+   * The valid range is from 1 to 180 seconds, inclusive.


I'm seeing the max read timeout as 60 seconds https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-customoriginconfig.html#cfn-cloudfront-distribution-customoriginconfig-originreadtimeout. Where does the 180 seconds come from?

This is in reference to this code; I added this because Note was missing.

aws-cdk/packages/aws-cdk-lib/aws-cloudfront-origins/lib/http-origin.ts

Lines 37 to 58 in b4daf84

/**

* Specifies how long, in seconds, CloudFront waits for a response from the origin, also known as the origin response timeout.

* The valid range is from 1 to 180 seconds, inclusive.

*

* Note that values over 60 seconds are possible only after a limit increase request for the origin response timeout quota

* has been approved in the target account; otherwise, values over 60 seconds will produce an error at deploy time.

*

* @default Duration.seconds(30)

*/

readonly readTimeout?: cdk.Duration;

/**

* Specifies how long, in seconds, CloudFront persists its connection to the origin.

* The valid range is from 1 to 180 seconds, inclusive.

*

* Note that values over 60 seconds are possible only after a limit increase request for the origin response timeout quota

* has been approved in the target account; otherwise, values over 60 seconds will produce an error at deploy time.

*

* @default Duration.seconds(5)

*/

readonly keepaliveTimeout?: cdk.Duration;

}

Thanks for the clarification!

colifran · 2024-02-15T23:02:28Z

packages/aws-cdk-lib/aws-cloudfront-origins/lib/function-url-origin.ts

+
+  /**
+   * Specifies how long, in seconds, CloudFront persists its connection to the origin.
+   * The valid range is from 1 to 180 seconds, inclusive.


Same as above.

colifran

This looks great! I just have one small question.

Pull request has been modified.

colifran

Nice job!

mergify · 2024-02-16T18:12:35Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-02-16T18:39:55Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 4fcbc6a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-02-16T18:40:25Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

### Reason for this change `origins.httpOrigin` requires a trick to specify the Lambda Functions URL. ### Description of changes This eases that pain and simplifies integration. ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

watany-dev added 3 commits February 14, 2024 05:12

add function url origin

76219c4

feat:(cloudfront-origins): adding FunctionURLOrigin

d6d0a3f

readme

1f0a772

github-actions bot added the p2 label Feb 14, 2024

aws-cdk-automation requested a review from a team February 14, 2024 10:17

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Feb 14, 2024

aws-cdk-automation previously requested changes Feb 14, 2024

View reviewed changes

watany-dev changed the title ~~feat(cloudfront-origin): Adding FunctionUrlOrigin~~ feat(cloudfront-origin): adding FunctionUrlOrigin Feb 14, 2024

fix readme.md

6f428cc

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 15, 2024

colifran reviewed Feb 15, 2024

View reviewed changes

colifran previously requested changes Feb 15, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 15, 2024

change comment

9208568

watany-dev force-pushed the cf-origin-lambda-url branch from 847b2d3 to 9208568 Compare February 16, 2024 05:07

watany-dev added 2 commits February 16, 2024 14:09

Merge branch 'aws:main' into cf-origin-lambda-url

5d503c0

doc fix

e279853

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 16, 2024

watany-dev requested a review from colifran February 16, 2024 07:51

colifran approved these changes Feb 16, 2024

View reviewed changes

Merge branch 'main' into cf-origin-lambda-url

4fcbc6a

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 16, 2024

mergify bot merged commit 2b0ed53 into aws:main Feb 16, 2024

github-actions bot mentioned this pull request Mar 1, 2024

Monthly PR metrics report - Feb 2023 #29328

Closed

This was referenced Mar 7, 2024

(aws-lambda/aws-cloudfront): FunctionUrls cannot be added to cloudfront as a http origin #20090

Closed

(lambda): Return domain name for Lambda Function Url #20254

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cloudfront-origin): adding FunctionUrlOrigin#29101

feat(cloudfront-origin): adding FunctionUrlOrigin#29101
mergify[bot] merged 8 commits intoaws:mainfrom
watany-dev:cf-origin-lambda-url

watany-dev commented Feb 14, 2024

Uh oh!

aws-cdk-automation left a comment

Uh oh!

colifran Feb 15, 2024

Uh oh!

watany-dev Feb 16, 2024

Uh oh!

colifran Feb 16, 2024

Uh oh!

colifran Feb 15, 2024

Uh oh!

watany-dev Feb 16, 2024

Uh oh!

colifran left a comment

Uh oh!

colifran left a comment

Uh oh!

mergify bot commented Feb 16, 2024

Uh oh!

aws-cdk-automation commented Feb 16, 2024

Uh oh!

mergify bot commented Feb 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	/**
	* Specifies how long, in seconds, CloudFront waits for a response from the origin, also known as the origin response timeout.
	* The valid range is from 1 to 180 seconds, inclusive.
	*
	* Note that values over 60 seconds are possible only after a limit increase request for the origin response timeout quota
	* has been approved in the target account; otherwise, values over 60 seconds will produce an error at deploy time.
	*
	* @default Duration.seconds(30)
	*/
	readonly readTimeout?: cdk.Duration;

	/**
	* Specifies how long, in seconds, CloudFront persists its connection to the origin.
	* The valid range is from 1 to 180 seconds, inclusive.
	*
	* Note that values over 60 seconds are possible only after a limit increase request for the origin response timeout quota
	* has been approved in the target account; otherwise, values over 60 seconds will produce an error at deploy time.
	*
	* @default Duration.seconds(5)
	*/
	readonly keepaliveTimeout?: cdk.Duration;
	}

Conversation

watany-dev commented Feb 14, 2024

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

colifran Feb 15, 2024

Choose a reason for hiding this comment

Uh oh!

watany-dev Feb 16, 2024

Choose a reason for hiding this comment

Uh oh!

colifran Feb 16, 2024

Choose a reason for hiding this comment

Uh oh!

colifran Feb 15, 2024

Choose a reason for hiding this comment

Uh oh!

watany-dev Feb 16, 2024

Choose a reason for hiding this comment

Uh oh!

colifran left a comment

Choose a reason for hiding this comment

Uh oh!

colifran left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 16, 2024

Uh oh!

aws-cdk-automation commented Feb 16, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Feb 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants