feat(pipes-enrichments): new EventBridge Pipes enrichments alpha module#29063
Merged
mergify[bot] merged 6 commits intoaws:mainfrom Feb 13, 2024
Merged
Conversation
kaizencc
reviewed
Feb 13, 2024
packages/@aws-cdk/aws-pipes-enrichments-alpha/test/lambda.test.ts
Outdated
Show resolved
Hide resolved
| }); | ||
| }); | ||
|
|
||
| it('should have only enrichment arn', () => { |
Contributor
There was a problem hiding this comment.
I think using it is fine but elsewhere in CDK we have been using test and we may eventually want parity if/when we stabilize this module.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
GavinZZ
pushed a commit
that referenced
this pull request
Feb 22, 2024
…le (#29063) ### Issue # (if applicable) Closes #<issue number here>. ### Reason for this change This PR adds a new alpha module to for EvenBridge pipes enrichments. This is the base setup for future work and additional enrichments. ### Description of changes The initial enrichment is the Lambda enrichment. ### Description of how you validated changes - [x] Unittests - [x] Integration test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #.
Reason for this change
This PR adds a new alpha module to for EvenBridge pipes enrichments.
This is the base setup for future work and additional enrichments.
Description of changes
The initial enrichment is the Lambda enrichment.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license