chore(prlint): update second comment to state exemption request has been submitted#29000
Merged
mergify[bot] merged 3 commits intomainfrom Feb 9, 2024
Merged
chore(prlint): update second comment to state exemption request has been submitted#29000mergify[bot] merged 3 commits intomainfrom
mergify[bot] merged 3 commits intomainfrom
Conversation
kaizencc
approved these changes
Feb 9, 2024
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
Code looks good, small comment. I am approving with the pr/do-not-merge label, which means that once my comment is addressed or discarded, you can remove the label and mergify will merge. No need to rerequest approval
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TheRealAmazonKendra
pushed a commit
that referenced
this pull request
Feb 9, 2024
…een submitted (#29000) ### Issue # (if applicable) Closes #28803 ### Reason for this change If a contributor requests an exemption or clarification for a PR, they will get a second message (due to the comment event) telling them again that they can request an exemption/clarification. This may confuse contributors, especially beginners. ### Description of changes Detect if an exempt request comment already exists, next comment would mention an request has been submitted and waiting for a maintainer's review. ### Description of how you validated changes unit tests *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #28803
Reason for this change
If a contributor requests an exemption or clarification for a PR, they will get a second message (due to the comment event) telling them again that they can request an exemption/clarification. This may confuse contributors, especially beginners.
Description of changes
Detect if an exempt request comment already exists, next comment would mention an request has been submitted and waiting for a maintainer's review.
Description of how you validated changes
unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license