Skip to content

feat(apigatewayv2-integrations): stepfunctions integration#28982

Merged
mergify[bot] merged 15 commits intoaws:mainfrom
badmintoncryer:28904-stepfunctionsIntegration
Feb 28, 2024
Merged

feat(apigatewayv2-integrations): stepfunctions integration#28982
mergify[bot] merged 15 commits intoaws:mainfrom
badmintoncryer:28904-stepfunctionsIntegration

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Feb 4, 2024 •
edited
Loading

Issue

Closes #28904.

Reason for this change

It is not possible to create an integration between Step Functions and HTTP API.

Description of changes

You can create integration by HttpStepFunctionsIntegration class:

declare const httpApi: apigwv2.HttpApi;
declare const stateMachine: sfn.StateMachine;

const integration = new HttpStepFunctionIntegration('StepFunctionIntegration', {
	stateMachine,
  })

    httpApi.addRoutes({
      path: '/jobs',
      methods: [apigwv2.HttpMethod.POST],
      integration,
    });

Description of how you validated changes

Added unit tests and integ test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Feb 4, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 4, 2024 21:14
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 4, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 5, 2024 16:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer force-pushed the 28904-stepfunctionsIntegration branch from e106689 to 593b9c7 Compare February 6, 2024 09:40
@badmintoncryer badmintoncryer force-pushed the 28904-stepfunctionsIntegration branch from a72e564 to 8b5f6ce Compare February 6, 2024 14:05
@badmintoncryer badmintoncryer marked this pull request as ready for review February 6, 2024 15:04
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 6, 2024
colifran
colifran previously approved these changes Feb 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your work on this.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 26, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Feb 26, 2024 •
edited
Loading

@colifran thank you for your review!!
But, mergify job seems to be failed. This is occured in other PR (#29086)
Could you solve it??

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Feb 27, 2024

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 27, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Feb 28, 2024

@kaizencc
I'm sorry for the sudden contact. As mentioned above, the Mergify job has failed for some reason.
The same problem is occurred at #29086
Could you tell me how to solve this?

@colifran
I apologize if you have already been working towards a solution!

@colifran
Copy link
Copy Markdown
Contributor

colifran commented Feb 28, 2024

@badmintoncryer sorry I missed your original message. I'm taking a look!

@mergify mergify bot dismissed colifran’s stale review February 28, 2024 14:35

Pull request has been modified.

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Feb 28, 2024

@colifran Thanks a lot!!

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 28, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 39f9267
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 28, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 19d75d6 into aws:main Feb 28, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 28, 2024
@badmintoncryer badmintoncryer deleted the 28904-stepfunctionsIntegration branch February 28, 2024 15:35
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@colifran colifran colifran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws_apigatewayv2: Can't define HTTP API Step Functions integration with JWT authorizer

3 participants

@badmintoncryer @colifran @aws-cdk-automation