Skip to content

feat(appsync): add the grant method to the imported GraphqlApi#29086

Merged
mergify[bot] merged 10 commits intoaws:mainfrom
badmintoncryer:23031-appsyncGrant
Feb 28, 2024
Merged

feat(appsync): add the grant method to the imported GraphqlApi#29086
mergify[bot] merged 10 commits intoaws:mainfrom
badmintoncryer:23031-appsyncGrant

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Feb 13, 2024

Issue

Closes #23031.

Reason for this change

The grantXx methods are implemented in the GraphqlApi class, but it could not be used with an imported graphql api.

Description of changes

Moved the implementation of the grantXx method from the GraphqlApi class to the GraphqlApiBase class."

Description of how you validated changes

I've added both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Feb 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 13, 2024 05:56
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 13, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 13, 2024 06:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer changed the title feat(appsync): grant method in the imported graphql api feat(appsync): execution of the grant method in an imported graphql api Feb 13, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review February 13, 2024 09:26
@badmintoncryer badmintoncryer changed the title feat(appsync): execution of the grant method in an imported graphql api feat(appsync): grant method in an imported graphql api Feb 13, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 13, 2024
@badmintoncryer badmintoncryer changed the title feat(appsync): grant method in an imported graphql api feat(appsync): add the grant method to the imported GraphqlApi Feb 13, 2024
go-to-k
go-to-k approved these changes Feb 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 19, 2024
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Feb 19, 2024

@go-to-k Thanks!

colifran
colifran previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- nice job!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 19, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Feb 20, 2024

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 20, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Feb 20, 2024

@colifran mergify cannot update this PR. How should I do..??

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 24, 2024

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@mergify mergify bot dismissed colifran’s stale review February 24, 2024 15:18

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 26, 2024
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Feb 26, 2024

@colifran
The Mergify job failed to merge this branch due to a conflict, which I have now resolved. Please review this PR again.

@badmintoncryer badmintoncryer mentioned this pull request Feb 26, 2024
Merged
1 task
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 28, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6427a9f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7e8239b into aws:main Feb 28, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 28, 2024
@badmintoncryer badmintoncryer deleted the 23031-appsyncGrant branch February 28, 2024 16:07
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+2 more reviewers

@go-to-k go-to-k go-to-k approved these changes

@colifran colifran colifran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

appsync-alpha: Add grant methods to IGraphqlApi

4 participants

@badmintoncryer @aws-cdk-automation @go-to-k @colifran