Skip to content

chore(migrate): add migrate information to AWS::CDK::Metadata#28958

Merged
mergify[bot] merged 2 commits intomainfrom
madeline-k/migrate-metadata
Feb 1, 2024
Merged

chore(migrate): add migrate information to AWS::CDK::Metadata#28958
mergify[bot] merged 2 commits intomainfrom
madeline-k/migrate-metadata

Conversation

@madeline-k
Copy link
Copy Markdown
Contributor

@madeline-k madeline-k commented Feb 1, 2024

This change adds a new context key to the cdk.json file when an app is generated by the cdk migrate cli command. If the context key "cdk-migrate" is true, then that information is added to the end of the analytics string in the AWS::CDK::Metadata resource.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 1, 2024 15:58
@github-actions github-actions bot added the p2 label Feb 1, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 1, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Feb 1, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@madeline-k madeline-k added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Feb 1, 2024
@madeline-k
Copy link
Copy Markdown
Contributor Author

Pipeline execution 30ae7676 was successful

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 1, 2024 18:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7c630ee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4f4da72 into main Feb 1, 2024
@mergify mergify bot deleted the madeline-k/migrate-metadata branch February 1, 2024 19:09
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TheRealAmazonKendra pushed a commit that referenced this pull request Feb 2, 2024
This change adds a new context key to the `cdk.json` file when an app is generated by the `cdk migrate` cli command. If the context key `"cdk-migrate"` is `true`, then that information is added to the end of the analytics string in the AWS::CDK::Metadata resource. 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
SankyRed pushed a commit that referenced this pull request Feb 8, 2024
This change adds a new context key to the `cdk.json` file when an app is generated by the `cdk migrate` cli command. If the context key `"cdk-migrate"` is `true`, then that information is added to the end of the analytics string in the AWS::CDK::Metadata resource. 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants