fix(lambda-event-sources): update s3-event-source to accept IBucket#28943
fix(lambda-event-sources): update s3-event-source to accept IBucket#28943mergify[bot] merged 12 commits intoaws:mainfrom
Conversation
GavinZZ
left a comment
There was a problem hiding this comment.
Can we add a README that documents this V2 class please?
|
Hey @GavinZZ Thanks for the comment, I've added readme. However, when I'm trying to run Update: Codebuild has run it successfully |
GavinZZ
left a comment
There was a problem hiding this comment.
Thanks! One minor comment and I'm good to approve.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…28943) ### Issue # (if applicable) Closes #4323 ### Reason for this change S3EventSource should accept `IBucket` instead of `Bucket`. `aws_s3.Bucket.from_bucket_name(...)` or `aws_s3.Bucket.from_bucket_arn(...)`, etc. returns aws_s3.IBucket type ### Description of changes Based on @otaviomacedo 's comment in #25782 , a new class `S3EventSourceV2` is implementd to accept `IBucket` instead of `Bucket`. And avoids breaking changes. ### Description of how you validated changes - unit test - integration test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Issue # (if applicable)
Closes #4323
Reason for this change
S3EventSource should accept
IBucketinstead ofBucket.aws_s3.Bucket.from_bucket_name(...)oraws_s3.Bucket.from_bucket_arn(...), etc. returns aws_s3.IBucket typeDescription of changes
Based on @otaviomacedo 's comment in #25782 , a new class
S3EventSourceV2is implementd to acceptIBucketinstead ofBucket. And avoids breaking changes.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license