chore: add breaking changes to end of PR template#28941
Merged
mergify[bot] merged 4 commits intoaws:mainfrom Jan 31, 2024
Merged
chore: add breaking changes to end of PR template#28941mergify[bot] merged 4 commits intoaws:mainfrom
mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
paulhcsun
reviewed
Jan 31, 2024
paulhcsun
approved these changes
Jan 31, 2024
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
SankyRed
pushed a commit
that referenced
this pull request
Feb 8, 2024
### Reason for this change We require breaking changes to be listed at the end of the PR description (see [here](https://github.com/aws/aws-cdk/blob/b32f47cfd65a5288e7bc2cc5a8a1f8e5f59032f8/CONTRIBUTING.md?plain=1#L620)), adding it to the template makes it easier for contributors to adhere to this ### Description of changes Add breaking changes format to end of PR template ### Description of how you validated changes n/a ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
We require breaking changes to be listed at the end of the PR description (see here), adding it to the template makes it easier for contributors to adhere to this
Description of changes
Add breaking changes format to end of PR template
Description of how you validated changes
n/a
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license